Log duration for various methods in AuthorizedProjectsWorker

What does this MR do and why?

• We are experiencing issues with the AuthorizedProjectsWorker, especially around how long each request is taking.

• The worker calls Users::RefreshAuthorizedProjectsService to calculate which records in the project_authorizations table need to be refreshed and saves those changes.

• This MR adds duration stats to the different steps in this service to figure out which part of the codebase needs to be optimised.

• No changelog needed since it's a developer facing change

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #484754 (closed)

changed milestone to %17.5

added Category:Permissions devopsgovern groupauthorization missed:17.4 priority2 sectionsec typemaintenance workflowin dev labels

assigned to @hmehra

added pipelinetier-1 label

added backend database databasereview pending labels

	1 Warning
	The master pipeline status page reported failures in rspec-ee system pg14 12/16 If these jobs fail in your merge request with the same errors, then they are not caused by your changes. Please check for any on-going incidents in the incident issue tracker or in the #master-broken Slack channel.

	2 Messages
	CHANGELOG missing: If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
	This merge request adds or changes files that require a review from the Database team.

This merge request requires a database review. To make sure these changes are reviewed, take the following steps:

1. Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
2. Prepare your MR for database review according to the docs.
3. Assign and mention the database reviewer suggested by Reviewer Roulette.

The following files require a review from the Database team:

• app/services/users/refresh_authorized_projects_service.rb

Reviewer roulette

Category	Reviewer	Maintainer
backend	@ahegyi (UTC+2, 9 hours behind author)	@atiwari71 (UTC+5.5, 5.5 hours behind author)
database	@lma-git (UTC-7, 18 hours behind author)	@jarka (UTC+2, 9 hours behind author)
groupauthentication	Reviewer review is optional for groupauthentication	@eduardosanz (UTC+2, 9 hours behind author)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added 1 commit

• 0186b54d - Log duration for various methods in AuthorizedProjectsWorker

Compare with previous version

added 1 commit

• d16330fb - Log duration for various methods in AuthorizedProjectsWorker

Compare with previous version

marked this merge request as ready

changed the description

added 1 commit

• e18be116 - Log duration for various methods in AuthorizedProjectsWorker

Compare with previous version

requested review from @sgarg_gitlab

Hey @dblessing would you do the initial backend and groupauthentication review please?

mentioned in issue #484754 (closed)

requested review from @dblessing

removed review request for @sgarg_gitlab

approved this merge request

added pipeline:mr-approved label

added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label

Before you set this MR to auto-merge

This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

Before you set this MR to auto-merge, please check the following:

• You are the last maintainer of this merge request
• The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
• This pipeline is recent enough (created in the last 8 hours)

If all the criteria above apply, please set auto-merge for this merge request.

See pipeline tiers and merging a merge request for more details.

requested review from @atiwari71 and @nmilojevic1

Generated by gitlab_quality-test_tooling.

---

Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

Click to expand

Job	File	Name	Duration	Expected duration
#7996230841	spec/features/admin/users/users_spec.rb#L177	Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking	66.5 s	< 50.13 s
#8035458195	spec/features/admin/users/users_spec.rb#L177	Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking	67.04 s	< 50.13 s

added rspec:slow test detected label

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for e18be116

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 35     | 0      | 1       | 0     | 36    | ✅     |
| Govern      | 38     | 0      | 0       | 0     | 38    | ✅     |
| Plan        | 32     | 0      | 0       | 0     | 32    | ✅     |
| Verify      | 12     | 0      | 0       | 0     | 12    | ✅     |
| Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
| Monitor     | 2      | 0      | 0       | 0     | 2     | ✅     |
| Data Stores | 19     | 0      | 0       | 0     | 19    | ✅     |
| Secure      | 2      | 0      | 0       | 0     | 2     | ✅     |
| Release     | 2      | 0      | 0       | 0     | 2     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 144    | 0      | 1       | 0     | 145   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-test-on-omnibus: test report for e18be116

expand test summary

+-------------------------------------------------------------+
|                       suites summary                        |
+--------+--------+--------+---------+-------+-------+--------+
|        | passed | failed | skipped | flaky | total | result |
+--------+--------+--------+---------+-------+-------+--------+
| Govern | 108    | 0      | 6       | 2     | 114   | ✅     |
| Create | 408    | 0      | 60      | 0     | 468   | ✅     |
+--------+--------+--------+---------+-------+-------+--------+
| Total  | 516    | 0      | 66      | 2     | 582   | ✅     |
+--------+--------+--------+---------+-------+-------+--------+

removed pipeline:run-e2e-omnibus-once label

approved this merge request

database LGTM!

@ahegyi can you please do the maintainer review for the database

added databasereviewed label and removed databasereview pending label

requested review from @ahegyi and removed review request for @nmilojevic1

approved this merge request

approved this merge request

resolved all threads

enabled automatic add to merge train when checks pass

started a merge train

merged

Hello @hmehra

The database team is looking for ways to improve the database review process and we would love your help!

If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:

@gitlab-org/database-team

And someone will be by shortly!

Thanks for your help!

This message was generated automatically. You're welcome to improve it.

mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#8882 (closed)

added workflowstaging-canary label and removed workflowin dev label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added workflowpost-deploy-db-staging label and removed workflowproduction label

added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label

added releasedcandidate label

mentioned in task #499416 (closed)

added releasedpublished label and removed releasedcandidate label