Reject empty content from chat history
This is a high priority MR for Switch to Chat Agent V2 (gitlab-org#13533 - closed). Please prioritize the review and merge.
What does this MR do and why?
This MR rejects empty content from chat history (e.g. ""
). I suspect that this is causing all messages must have non-empty content except for the optional final assistant message
exception.
Closes Exclude a pair of user and assistant role messa... (#479460 - closed) Seeing A1002 Duo Chat error message (#494004 - closed) and Handle Anthropic invalid_request_error in Duo Chat (#493681 - closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
assigned to @shinya.maeda
added devopsai-powered groupduo chat sectiondata-science typebug labels
added pipelinetier-1 label
removed pipelinetier-1 label
added Category:Duo Chat label
changed milestone to %17.5
- Resolved by Matthias Käppler
@brytannia @lulalala Can either of you review and pass other for merge? Thanks!
requested review from @brytannia and @lulalala
- A deleted user
added backend label
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @shubhamkrai
(UTC+2, 7 hours behind author)
@.luke
(UTC+12, 3 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded pipeline:mr-approved label
removed review request for @brytannia
removed review request for @lulalala
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels
requested review from @mkaeppler
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 03706cf9expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 128 | 0 | 18 | 0 | 146 | ✅ | | Verify | 46 | 0 | 2 | 0 | 48 | ✅ | | Govern | 72 | 0 | 0 | 0 | 72 | ✅ | | Package | 24 | 0 | 11 | 0 | 35 | ✅ | | Plan | 75 | 0 | 1 | 1 | 76 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 400 | 0 | 34 | 1 | 434 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
started a merge train
mentioned in commit 8756b28e
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#8592 (closed)
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#8594 (closed)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue #494004 (closed)
mentioned in issue #479460 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label