Empty state for branch specific MR approvals
What does this MR do and why?
When viewing MR approval rules per branch from a branch rule details page, there's a chance there is no rule and a default project rules do not apply. In that case the table appeared empty, with only a table header visible. This commit adds an empty state text for such cases.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Go to Project / Settings / Repository / Branch rules
- Click View details for a branch you protected OR create a new branch rule
- Scroll down to MR approvals. If there are no rules, you should be able to see the empty text.
- Add MR approval rule for that branch. Make sure the empty state disappear.
- Go to Project / Settings / Merge requests and scroll to MR approvals.
- Make sure you can't see that empty state, even when you delete all named rules.
Related to #481761 (closed)
Merge request reports
Activity
changed milestone to %17.5
assigned to @psjakubowska
added 1 commit
- 85ad6180 - Add an empty state for MR approvals per branch
- Resolved by Simon Knox
- Resolved by Simon Knox
- Resolved by Simon Knox
- Resolved by Paulina Sedlak-Jakubowska
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Category Reviewer Maintainer frontend @lwanko
(UTC+2, same timezone as author)
@psimyn
(UTC+10, 8 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger
requested review from @lwanko and @brendan777
added workflowin review label and removed workflowin dev label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 19f62503 and 85ad6180
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.35 MB 4.35 MB - 0.0 % mainChunk 3.3 MB 3.3 MB - 0.0 %
Note: We do not have exact data for 19f62503. So we have used data from: b32e61e0.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded pipeline:mr-approved label
added pipelinetier-2 label
removed review request for @brendan777
requested review from @psimyn
removed review request for @lwanko