Skip to content
Snippets Groups Projects

Empty state for branch specific MR approvals

What does this MR do and why?

When viewing MR approval rules per branch from a branch rule details page, there's a chance there is no rule and a default project rules do not apply. In that case the table appeared empty, with only a table header visible. This commit adds an empty state text for such cases.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2024-09-24_at_10.50.47 Screenshot_2024-09-24_at_10.32.56
Screenshot_2024-09-24_at_10.51.01 Screenshot_2024-09-24_at_10.33.08

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Go to Project / Settings / Repository / Branch rules
  2. Click View details for a branch you protected OR create a new branch rule
  3. Scroll down to MR approvals. If there are no rules, you should be able to see the empty text.
  4. Add MR approval rule for that branch. Make sure the empty state disappear.
  5. Go to Project / Settings / Merge requests and scroll to MR approvals.
  6. Make sure you can't see that empty state, even when you delete all named rules.

Related to #481761 (closed)

Edited by Paulina Sedlak-Jakubowska

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Paulina Sedlak-Jakubowska
  • Paulina Sedlak-Jakubowska
  • Paulina Sedlak-Jakubowska marked this merge request as ready

    marked this merge request as ready

  • Paulina Sedlak-Jakubowska changed the description

    changed the description

  • requested review from @lwanko and @brendan777

  • added workflowin review label and removed workflowin dev label

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 19f62503 and 85ad6180

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.35 MB 4.35 MB - 0.0 %
    mainChunk 3.3 MB 3.3 MB - 0.0 %

    Note: We do not have exact data for 19f62503. So we have used data from: b32e61e0.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Brendan Lynch approved this merge request

    approved this merge request

  • Brendan Lynch removed review request for @brendan777

    removed review request for @brendan777

  • Lukas Wanko requested review from @psimyn

    requested review from @psimyn

  • Lukas Wanko removed review request for @lwanko

    removed review request for @lwanko

  • Lukas Wanko approved this merge request

    approved this merge request

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading