Updated documentation generator for custom roles

• Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA

What does this MR do and why?

• Updated the docs generator for custom roles to a new format (as described in #482752 (closed))
• Compiled custom roles docs
• Removed 2 unnecessary methods in docs generator for custom roles

Screenshots or screen recordings

How to set up and validate locally

• Run bundle exec rake gitlab:custom_roles:compile_docs to compile the docs
• Run Gitlab Docs in GDK

Related to #482752 (closed)

added devopsgovern groupauthorization sectionsec typemaintenance labels

added pipelinetier-1 label

Thanks for your contribution to GitLab @Florian_Lang! 🎉

• If you need help, page a coach by clicking here or come say hi on Discord.
• When you're ready, request a review by clicking here.
• We welcome AI-generated contributions! Read more/check the box at the top of the merge request description.
• To add labels to your merge request, comment @gitlab-bot label ~"label1" ~"label2".

This message was generated automatically. You're welcome to improve it.

added Community contribution workflowin dev labels

assigned to @Florian_Lang

changed the description

added linked-issue label

added Category:Permissions label

	153 Warnings
⚠️	de94dc21: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
⚠️	de94dc21: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	81ec0f93: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	72ef3a59: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	63c34338: The commit subject and body must be separated by a blank line. For more information, take a look at our Commit message guidelines.
⚠️	63c34338: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	1ea982f3: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	8847fd06: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	34243a3a: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	1db21c59: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	17bd6edd: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	7a71e994: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
⚠️	c85a2bbe: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
⚠️	5cda893f: The commit subject and body must be separated by a blank line. For more information, take a look at our Commit message guidelines.
⚠️	9344c4dd: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	79c0ca78: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	ec73bc78: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	8588173d: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	935b3cfe: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	77108c49: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	91b29d21: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	f5e5d7e3: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	22fb9e56: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	c91f658f: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	f4c89c27: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
⚠️	2297f0eb: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	44c76d67: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
⚠️	44c76d67: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	336b2989: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	2144bdac: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	a660e8c9: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
⚠️	a660e8c9: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	54aac068: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	5e330b24: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	12ec00d4: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	acbf4003: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	9e9bedf6: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	78ab5746: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
⚠️	78ab5746: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	8fd169d1: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	5d6178f0: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
⚠️	5d6178f0: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	7c5271e9: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
⚠️	aa4cd9ff: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	0b3bedad: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	9d16ea92: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
⚠️	5c8428cc: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	8d749216: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	5cde9d74: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	2d487f79: Use full URLs instead of short references (gitlab-org/gitlab#123 or !123), as short references are displayed as plain text outside of GitLab. For more information, take a look at our Commit message guidelines.
⚠️	2da1aff1: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
⚠️	c6f66987: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	9618227f: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	2b96acd3: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	dc686b0c: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
⚠️	e9e2a568: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	bd236b98: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	30376537: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	65a992c6: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	c4ff30e5: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	66fd767d: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
⚠️	e3020839: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	32177974: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	5a49af21: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	937b4ffa: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	c1f38fd6: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	4f98c777: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	fc4e3fb5: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	d86c9649: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	dffd4e63: The commit subject and body must be separated by a blank line. For more information, take a look at our Commit message guidelines.
⚠️	dffd4e63: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	1c7b4832: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	0cc2fe60: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	b3225fa9: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
⚠️	fdcdd81b: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	0047910c: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	ab39e45f: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	5b45fbce: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	28230129: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	bc4b7118: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	b33dc6ee: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	fb596b9d: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	3edb28d4: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	dad76a55: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	4fc2180e: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	8786c721: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	31036076: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
⚠️	916e8ec1: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	8923b6c4: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	dfbe4c20: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
⚠️	b94e627a: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	5adea6d4: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
⚠️	e9a32751: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
⚠️	0aa1b840: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	7c592d9f: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
⚠️	93bbdec1: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
⚠️	02087f7d: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	d0b22161: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	a90bf903: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	5611eff6: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	d5d59609: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
⚠️	6a4138b7: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	8147ec5f: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	c516372d: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
⚠️	ce90ec04: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	477b74ce: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	e9d20814: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	6122d1db: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	806a8fe1: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
⚠️	b1a51262: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	5f37be17: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	a601938d: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	7ef0d180: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
⚠️	f98dc016: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
⚠️	81385243: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	d52fd21f: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	341930ba: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	27445146: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	0f8efd56: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	be92dbe2: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	8897c70d: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	05c713c7: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	27c91e5c: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	61ae6641: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	862608f1: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	7243a2f0: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	d35097c0: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines.
⚠️	e8b6296b: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	54076ebb: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
⚠️	54076ebb: The commit subject must not end with a period. For more information, take a look at our Commit message guidelines.
⚠️	d539e636: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	d979f35b: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	4692770a: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
⚠️	4692770a: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	1ef2ce29: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
⚠️	1ef2ce29: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	1565b3d1: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	d52c640f: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	7bbf6680: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines.
⚠️	46cb7a22: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
⚠️	46cb7a22: The commit subject must not end with a period. For more information, take a look at our Commit message guidelines.
⚠️	14044991: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	7e443c8f: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	b2b28692: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	70fe4968: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	2a7210bf: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
⚠️	2a7210bf: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	491e51ff: The commit subject and body must be separated by a blank line. For more information, take a look at our Commit message guidelines.
⚠️	da9819f1: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	475cdbaa: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	8fd743ea: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠️	2e75af6c: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
⚠️	This merge request has more than 20 commits which may cause issues in some of the jobs. If you see errors like missing commits, please consider squashing some commits so it is within 20 commits.

	1 Message
📖	This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

Documentation review

The following files require a review from a technical writer:

• doc/user/custom_roles/abilities.md (Link to current live version)

The review does not need to block merging this merge request. See the:

• Metadata for the *.md files that you've changed. The first few lines of each *.md file identify the stage and group most closely associated with your docs change.
• The Technical Writer assigned for that stage and group.
• Documentation workflows for information on when to assign a merge request for review.

Reviewer roulette

Category	Reviewer	Maintainer
backend	@bhrai (UTC+1)	@terrichu (UTC-5)
~"Tooling"	Reviewer review is optional for ~"Tooling"	@rymai (UTC+1)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the 🔁 danger-review job that generated this comment.

Generated by 🚫 Danger

@gitlab-bot ready

Posted via contributors.gitlab.com.

added workflowready for review label and removed workflowin dev label

Hi @axil! Please review this documentation merge request. This message was generated automatically. You're welcome to improve it.

added documentation twtriaged labels

requested review from @axil

@axil, this Community contribution is ready for review.

• Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
• If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.

This message was generated automatically. You're welcome to improve it.

@jarka can you review this MR for @Florian_Lang, please?

removed review request for @axil

requested review from @jarka

approved this merge request

Thanks @Florian_Lang , looks great! @hmehra could you please take over the maintainer review?

Thanks @Florian_Lang.

@jarka I am a little skeptical about merging this change just yet, because the title change is not reflected in the UI just yet. For instance, the title for read_crm_contract is View CRM contract but the UI still shows Read CRM contract. I know it's a small change, but do we an MR open that is supposed to reflect the title on the UI?

@hmehra I just created !167405 (merged) which adjusts the GraphQL Endpoint so in the UI the title is shown instead of the "old" name. But I am not sure which MR should be merged first.

@Florian_Lang the GraphQL MR would need to be merged first. Thank you for work on that, I have left some suggestions on that MR.

@Florian_Lang I am removing myself as a reviewer for now, please add me back when the MR is ready for a re-review.

requested review from @hmehra and removed review request for @jarka

added pipeline:mr-approved label

added pipelinetier-2 label and removed pipelinetier-1 label

Before you set this MR to auto-merge

This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3.

Before you set this MR to auto-merge, please check the following:

• You are the last maintainer of this merge request
• The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
• This pipeline is recent enough (created in the last 8 hours)

If all the criteria above apply, please set auto-merge for this merge request.

See pipeline tiers and merging a merge request for more details.

changed milestone to %17.5

added 261 commits

• 8ee0578a...f6066607 - 259 commits from branch gitlab-org:master
• 1fdc0282 - Added `title` field to new ability admin_protected_branch
• de94dc21 - Merge remote-tracking branch 'origin/482750-add-title-to-new-custom-ability'...

Compare with previous version

reset approvals from @jarka by pushing to the branch

added 1 commit

• 879e7a16 - Compiled custom roles docs

Compare with previous version

mentioned in merge request !167405 (merged)

@hmehra, this Community contribution was recently assigned to you for review.

• Do you still have capacity to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
• Add the workflowin dev label if the merge request needs action from the author.

This message was generated automatically. You're welcome to improve it.

added automation:reviewers-reminded label

added workflowin dev label and removed workflowready for review label

removed automation:reviewers-reminded label

removed review request for @hmehra

@Florian_Lang, it seems we're waiting on an action from you for approximately two weeks.

• Do you still have capacity to work on this? If not, you might want to close this MR and/or ask someone to take over.
• Do you need help in getting it ready? At any time, you can:
  • ask for help with @gitlab-bot help.
  • initiate a mentor session on Discord.
• If you're actually ready for a review, you can post @gitlab-bot ready.

This message was generated automatically. You're welcome to improve it.

added automation:author-reminded label

@gitlab-bot ready

added workflowready for review label and removed workflowin dev label

Hi Coach @a_akgun, this Community contribution is ready for review or needs your coaching.

• Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
• If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
• Please ensure the group's Product Manager has validated the linked issue.

This message was generated automatically. You're welcome to improve it.

Moved to workflowin review

@hmehra could you pls continue reviewing?

Thanks for the updates @Florian_Lang. I just have two suggestions. I would also recommend, rebasing with master and squashing the commits into one that follows our commit guidelines. Back to you 🏓

removed automation:author-reminded label

requested review from @a_akgun

added AppSecWorkflowin-progress label

requested review from @hmehra

removed review request for @a_akgun

added backend label

changed milestone to %17.6

suggestion: we do need support for feature-flags for when we introduce newer abilities. They can go in the Introduced in column, such as:

Introduced in GitLab 16.1 with a flag named x. Disabled by default.

Do I understand it right that if the feature flag is enabled it should only show die Gitlab version it was introduced in and if the feature flag hasn't been enable the message above should show up?

@hmehra i forgot the mention you here

@Florian_Lang if the custom ability is behind a feature flag, such as custom_ability_read_admin_dashboard then it should say the milestone it was introduced in. If the feature flag is default_enabled: false then Disabled by default should be added.

suggestion: the mismatch with the UI is still there. We should match the docs with the UI

removed review request for @hmehra

Hi @hmehra 👋

We noticed this MR is marked as workflowready for review but no reviewer is assigned. workflowin dev has automatically been applied to this MR based on the likelihood the review is finished. If additional reviews are still required, please assign a reviewer and reapply workflowready for review.

@Florian_Lang you may also request a review by commenting @gitlab-bot ready. You can also assign reviewers directly using @gitlab-bot ready @user1 @user2 if you know the relevant reviewer(s), such as those who were involved in a related issue.

This message was generated automatically. You're welcome to improve it.

added workflowin dev label and removed workflowready for review label

requested review from @hmehra

removed review request for @hmehra

@Florian_Lang, it seems we're waiting on an action from you for approximately two weeks.

• Do you still have capacity to work on this? If not, you might want to close this MR and/or ask someone to take over.
• Do you need help in getting it ready? At any time, you can:
  • ask for help with @gitlab-bot help.
  • initiate a mentor session on Discord.
• If you're actually ready for a review, you can post @gitlab-bot ready.

This message was generated automatically. You're welcome to improve it.

added automation:author-reminded label

added idle label

mentioned in issue #482752 (closed)

removed idle label

added 15395 commits

• 879e7a16...e6e7ab63 - 15394 commits from branch gitlab-org:master
• b60e88fe - Merge branch 'master' into 482752-updated-custom-roles-docs-generator

Compare with previous version

closed

@Florian_Lang, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

1. React with a 👍 or a 👎 on this comment to describe your experience.
2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

As a benefit of being a GitLab Community Contributor, you have access to GitLab Duo, our AI-powered features. With Code Suggestions, Chat, Root Cause Analysis and more AI-powered features, GitLab Duo helps to boost your efficiency and effectiveness by reducing the time required to write and understand code and pipelines. Visit the GitLab Duo documentation to learn more about the benefits.

Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.

Thanks for your help! ❤️

This message was generated automatically. Improve it or delete it.