Filter out duplicate milestone results in filter search bar
What does this MR do and why?
When a user searches milestones, there can be duplicate results for milestones in different scopes that have the same title.
This MR filters those duplicates out of search results, so that each milestone name only appears once in search results.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
Filter results (no change)
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Check out this branch
- In the GDK, make sure your user has access to 2 groups that each have a milestone that share the same title.
- In each of those two groups, create an issue
- Assign your user
- apply that milestone
- Go to your user's assigned issues dashboard page
- Search for that milestone
- You will see that the milestone name only appears once in search results.
- Filter on the milestone
- You will see that both of the issues you created in step 3 appear in the filter results
Related to #456346 (closed), #474921 (closed)
Merge request reports
Activity
changed milestone to %17.5
assigned to @clavimoniere
removed missed:17.0 label
removed missed:17.4 label
removed missed:17.1 label
removed missed:17.2 label
removed missed:17.3 label
removed workflowin review label
added pipelinetier-1 label
- A deleted user
added frontend label
1 Warning This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:app/assets/javascripts/vue_shared/components/filtered_search_bar/tokens/milestone_token.vue
Reviewer roulette
Category Reviewer Maintainer frontend @aalakkad
(UTC+3, 7 hours ahead of author)
@ealcantara
(UTC+2, 6 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Chad Lavimoniere
cc @nickleonard, this was a fix I wanted to get in in 17.0 but didn't make it
- Resolved by Chad Lavimoniere
@cngo since you're a project management team member, can you give this a fe maintainer review?
requested review from @cngo
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 11799e29 and 8e696e5f
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.35 MB 4.35 MB - 0.0 % mainChunk 3.29 MB 3.29 MB - 0.0 %
Note: We do not have exact data for 11799e29. So we have used data from: cdec6407.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 8e696e5fexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 128 | 0 | 18 | 0 | 146 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 75 | 0 | 1 | 1 | 76 | ✅ | | Package | 24 | 0 | 11 | 0 | 35 | ✅ | | Govern | 72 | 0 | 0 | 0 | 72 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Verify | 46 | 0 | 2 | 0 | 48 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 400 | 0 | 34 | 1 | 434 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-omnibus:
test report for 8e696e5fexpand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Plan | 82 | 0 | 9 | 0 | 91 | ✅ | | Create | 405 | 0 | 60 | 0 | 465 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 487 | 0 | 69 | 0 | 556 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
removed pipeline:run-e2e-omnibus-once label
started a merge train
mentioned in commit 7d586801
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#8584 (closed)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!3429 (merged)