Skip to content
Snippets Groups Projects

MR approval rule promotion migration

Merged Sascha Eggenberger requested to merge approval-rule-promo-migration into master

What does this MR do and why?

Migrates GlCard to Banner

  • Fixes a small spacing issue when the promo does not apply

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
promo_before promo_after
before after

How to set up and validate locally

  1. Follow the steps outlined in !75148 (merged)
  2. Open a new MR, check the Approval rules

Related to #474921 (closed), #476988

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Doug Stull
  • Doug Stull requested review from @sheldonled and removed review request for @dstull

    requested review from @sheldonled and removed review request for @dstull

  • Doug Stull approved this merge request

    approved this merge request

  • added 1 commit

    • 7de31407 - MR approval rule promotion migration

    Compare with previous version

  • Sascha Eggenberger reset approvals from @dstull by pushing to the branch

    reset approvals from @dstull by pushing to the branch

  • Doug Stull mentioned in issue #497313

    mentioned in issue #497313

  • Doug Stull approved this merge request

    approved this merge request

  • Sascha Eggenberger requested review from @anna_vovchenko and removed review request for @sheldonled

    requested review from @anna_vovchenko and removed review request for @sheldonled

  • Anna Vovchenko approved this merge request

    approved this merge request

  • added 1 commit

    • 52eeb3bc - MR approval rule promotion migration

    Compare with previous version

  • Sascha Eggenberger reset approvals from @dstull and @anna_vovchenko by pushing to the branch

    reset approvals from @dstull and @anna_vovchenko by pushing to the branch

  • added 1 commit

    • f1e98729 - MR approval rule promotion migration

    Compare with previous version

  • Anna Vovchenko approved this merge request

    approved this merge request

  • Anna Vovchenko resolved all threads

    resolved all threads

  • Anna Vovchenko enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Anna Vovchenko added this merge request to the merge train at position 4

    added this merge request to the merge train at position 4

  • Anna Vovchenko mentioned in commit 2029e0b1

    mentioned in commit 2029e0b1

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading