MR approval rule promotion migration
What does this MR do and why?
Migrates GlCard
to Banner
- Fixes a small spacing issue when the promo does not apply
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Follow the steps outlined in !75148 (merged)
- Open a new MR, check the
Approval rules
Related to #474921 (closed), #476988
Merge request reports
Activity
changed milestone to %17.5
assigned to @seggenberger
added devopsfoundations label
added groupacquisition label and removed devopsfoundations groupux paper cuts labels
added devopsfoundations label
added devopsgrowth label and removed devopsfoundations label
- Resolved by Anna Vovchenko
added devopsfoundations groupux paper cuts sectioncore platform labels and removed devopsgrowth groupacquisition sectiondev labels
added pipelinetier-1 label
2 Warnings The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.This merge request contains lines with testid selectors. Please ensure e2e:test-on-omnibus
job is run.testid
selectorsThe following changed lines in this MR contain
testid
selectors:ee/app/assets/javascripts/approvals/mr_edit/free_tier_promo.vue
+ 'data-testid': 'promo-dismiss-btn', - <gl-button variant="link" :icon="icon" data-testid="collapse-btn" @click="toggleCollapse"> + data-testid="collapse-btn" - <gl-card class="gl-new-card" data-testid="mr-approval-rules"> + data-testid="mr-approval-rules"
If the
e2e:test-on-omnibus
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:test-on-omnibus-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @jmontal
(UTC-6, 8 hours behind author)
@anna_vovchenko
(UTC+3, 1 hour ahead of author)
UX @jmiocene
(UTC+2, same timezone as author)
Maintainer review is optional for UX Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits fcf93c07 and f1e98729
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.37 MB 4.37 MB - 0.0 % mainChunk 3.3 MB 3.3 MB - 0.0 %
Note: We do not have exact data for fcf93c07. So we have used data from: 94ed792c.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangerremoved review request for @dstull
- Resolved by Anna Vovchenko
I'm able to see the spacing fix on my GDK, and @paintedbicycle-gitlab shared a screenshot of the promo on his. so I say
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
removed review request for @jmiocene
requested review from @paintedbicycle-gitlab
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for f1e98729expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 128 | 0 | 18 | 0 | 146 | ✅ | | Plan | 76 | 0 | 0 | 1 | 76 | ✅ | | Govern | 73 | 0 | 0 | 0 | 73 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 24 | 0 | 11 | 0 | 35 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Verify | 45 | 0 | 2 | 0 | 47 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 401 | 0 | 33 | 1 | 434 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
removed review request for @paintedbicycle-gitlab
requested review from @dstull
- Resolved by Sascha Eggenberger
- Resolved by Doug Stull
requested review from @sheldonled and removed review request for @dstull
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
reset approvals from @dstull by pushing to the branch
mentioned in issue #497313
requested review from @anna_vovchenko and removed review request for @sheldonled
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger
reset approvals from @dstull and @anna_vovchenko by pushing to the branch
- Resolved by Anna Vovchenko
added this merge request to the merge train at position 4
mentioned in commit 2029e0b1