Skip to content

Add rubocop rule to use Gitlab::Popen for popen3

Luke Duncalfe requested to merge rubocop-popen3 into master

What does this MR do?

Rubocop rule

Adds a rubocop rule to use Gitlab::Popen instead of popen3. Our Popen module contains methods that wrap Open3.popen3 in a way that avoids deadlocks.

Code change

Change one instance in our Rails app which was susceptible to a deadlock from using Open3.popen3 to Gitlab::Popen.popen_with_detail.

Documentation change

Developer documentation added for the Gitlab::Popen module methods.

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

Edited by Luke Duncalfe

Merge request reports