Skip to content

Add some fixes for the trial flow

What does this MR do?

  • Fix some syntax errors on _skip_trial.html.haml partial.
  • Persist form data after validation error on sign up form.
  • Persist form data after validation error on company info form.
  • Fix a broken spec.
  • Add some missing translations.

Additionally I've found the following issues that are not fixed in this MR

Sometimes the Country dropdown is not loading the list of countries:

Screen_Shot_2019-09-12_at_5.50.38_PM

When loading the Step 2, the UI transformation for the dropdowns is a bit notorious:

step2

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Rubén Dávila

Merge request reports