Fix N+1 in cluster agents resolver

What does this MR do and why?

This spec was quarantined a while ago as it was failing intermittently (see #350868 (comment 817969674) for initial investigation).

Removing the quarantine revealed that there was indeed an N+1 loading user_detail and user_preference records. I didn't find a definitive reason for this to be failing only some of the time, but with the new preloads added I cannot replicate the failure.

#350868 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Tiger Watson

Merge request reports

Loading