Migrate Merge Request empty result page to EmptyResult component
What does this MR do and why?
Migrate Merge Request empty result page to EmptyResult component
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Merge request reports
Activity
changed milestone to %17.4
added UX Paper Cuts groupcode review typemaintenance labels
assigned to @jmiocene
mentioned in epic gitlab-org#15100
added pipelinetier-1 label
added devopscreate sectiondev labels
1 Warning This merge request contains lines with testid selectors. Please ensure e2e:test-on-omnibus
job is run.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/views/shared/empty_states/_merge_requests.html.haml
- empty_state_options: { data: { testid: 'issuable-empty-state' } }, + = render ::Layouts::EmptyResultComponent.new(type: :filter, data: { testid: 'issuable-empty-state' })
If the
e2e:test-on-omnibus
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:test-on-omnibus-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer backend @hmerscher
(UTC+2, same timezone as author)
@suraj_tripathy
(UTC+5.5, 3.5 hours ahead of author)
frontend @ramistry
(UTC+5.5, 3.5 hours ahead of author)
@xanf
(UTC+3, 1 hour ahead of author)
test for spec/features/*
@hmerscher
(UTC+2, same timezone as author)
Maintainer review is optional for test for spec/features/*
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Julia Miocene
@annabeldunstone
Could you please review UX here?
requested review from @annabeldunstone
removed review request for @annabeldunstone
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 7a037e3bexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 46 | 0 | 2 | 0 | 48 | ✅ | | Create | 128 | 0 | 17 | 0 | 145 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Plan | 75 | 0 | 1 | 1 | 76 | ✅ | | Govern | 72 | 0 | 0 | 0 | 72 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 24 | 0 | 11 | 0 | 35 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 400 | 0 | 33 | 1 | 433 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-omnibus:
test report for f3542505expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Create | 553 | 0 | 72 | 1 | 625 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 553 | 0 | 72 | 1 | 625 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
- Resolved by Illya Klymov
requested review from @obaiye
added 1 commit
- a548d4a9 - Migrate Merge Request empty result page to EmptyResult component
added 1 commit
- 7783f064 - Migrate Merge Request empty result page to EmptyResult component
- Resolved by Illya Klymov
requested review from @jmontal
- Resolved by Julia Miocene
- Resolved by Julia Miocene
added 1 commit
- f3542505 - Migrate Merge Request empty result page to EmptyResult component
requested review from @seanarnold and removed review request for @jmontal
requested review from @jarka and removed review request for @seanarnold and @obaiye
requested review from @xanf
removed review request for @jarka
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
removed pipeline:run-e2e-omnibus-once label
aborted automatic add to merge train because the source branch was updated. Learn more.
added 1911 commits
-
f3542505...8101e7db - 1910 commits from branch
master
- 7a037e3b - Migrate Merge Request empty result page to EmptyResult component
-
f3542505...8101e7db - 1910 commits from branch
changed milestone to %17.5
added missed:17.4 label
- Resolved by Illya Klymov
@xanf could you please push the button one more time? There were some pipeline errors, I rebased the branch
started a merge train
mentioned in commit f7365059
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label