Skip to content
Snippets Groups Projects

Migrate Merge Request empty result page to EmptyResult component

Merged Julia Miocene requested to merge empty-result-9 into master
All threads resolved!

What does this MR do and why?

Migrate Merge Request empty result page to EmptyResult component

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
CleanShot_2024-09-07_at_16.18.10_2x CleanShot_2024-09-07_at_16.21.18_2x

How to set up and validate locally

Go to http://gdk.test:3000/dashboard/merge_requests?scope=all&state=opened&assignee_username=root&milestone_title=%23upcoming

#469616 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Oiza Baiye
  • I'm not yet familiar with the E2E test code, but it's worth checking that removing the component doesn't cause other issues. Beyond that, I agree with Jay to get the failing tests passing.

  • Oiza Baiye requested changes

    requested changes

  • Julia Miocene added 1 commit

    added 1 commit

    • f3542505 - Migrate Merge Request empty result page to EmptyResult component

    Compare with previous version

  • Oiza Baiye approved this merge request

    approved this merge request

  • Jay Montal approved this merge request

    approved this merge request

  • Jay Montal requested review from @seanarnold and removed review request for @jmontal

    requested review from @seanarnold and removed review request for @jmontal

  • Julia Miocene requested review from @jarka and removed review request for @seanarnold and @obaiye

    requested review from @jarka and removed review request for @seanarnold and @obaiye

  • Julia Miocene requested review from @xanf

    requested review from @xanf

  • Jarka Košanová approved this merge request

    approved this merge request

  • Jarka Košanová removed review request for @jarka

    removed review request for @jarka

  • Illya Klymov resolved all threads

    resolved all threads

  • Illya Klymov approved this merge request

    approved this merge request

  • Illya Klymov enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Julia Miocene aborted automatic add to merge train because the source branch was updated. Learn more.

    aborted automatic add to merge train because the source branch was updated. Learn more.

  • Julia Miocene added 1911 commits

    added 1911 commits

    Compare with previous version

  • changed milestone to %17.5

  • Illya Klymov resolved all threads

    resolved all threads

  • merged

  • Illya Klymov mentioned in commit f7365059

    mentioned in commit f7365059

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading