Skip to content

Fix leading of CiIcon text and make sure it is vertically centered

Chad Lavimoniere requested to merge 20240906-clavimoniere-ciicon-text into master

What does this MR do and why?

Prevent the text in a CiIcon component from inheriting line height from a parent element, and make sure that it is vertically centered.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Usage Before After
MR Pipelines page
(No change)
image image
Job page
(No change)
image image
Job artifact page
(Fixed)
image image

How to set up and validate locally

  1. Check out this branch
  2. In the GDK, ensure you have a pipeline job that creates artifacts
  3. Make that job run
  4. Visit the artifacts browse page for the job
  5. The CiIcon with the job status in the page header will not be malformed.

Merge request reports