Fix deploy key overflow issue in drawer
What does this MR do and why?
while verifying !165124 (merged), i noticed i missed a spot
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Add a deploy key with read-write permission for that project. To test this MR, make the name extra long
- Go to *Project / Settings / Repository / Protected branches and set the deploy key in Allowed to push and merge dropdown.
- Scroll up to Project / Settings / Repository / Branch rules and click View details for a branch you protected with the key.
- When on Branch rule details page, you can see your deploy key in the Allowed to push and merge section.
- Click edit to open the drawer, UI should not overflow on small screens
Merge request reports
Activity
assigned to @ms.mondrian
changed milestone to %17.4
added pipelinetier-1 label and removed pipelinetier-3 label
2 Warnings You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:app/assets/javascripts/vue_shared/components/list_selector/deploy_key_item.vue
Reviewer roulette
Category Reviewer Maintainer frontend @aalakkad
(UTC+3)
@ohoral
(UTC+3)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Stanislav Lashmanov
@agulina could you plz take a look at this smol fix for an overflow issue? i fixed two other places already and missed this one
requested review from @agulina
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 72eb36e8 and e3d67aa2
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.34 MB 4.34 MB - 0.0 % mainChunk 3.27 MB 3.27 MB - 0.0 %
Note: We do not have exact data for 72eb36e8. So we have used data from: 10d1dfec.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Stanislav Lashmanov
Hey @slashmanov,
would you have time to look at this merge request, please? Thanks!
requested review from @slashmanov
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for e3d67aa2expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 73 | 0 | 0 | 0 | 73 | ✅ | | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Create | 128 | 0 | 16 | 0 | 144 | ✅ | | Govern | 72 | 0 | 0 | 0 | 72 | ✅ | | Secure | 3 | 0 | 0 | 0 | 3 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Package | 20 | 0 | 12 | 0 | 32 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 389 | 0 | 32 | 0 | 421 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-omnibus:
test report for e3d67aa2expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Create | 557 | 0 | 68 | 0 | 625 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 557 | 0 | 68 | 0 | 625 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
removed pipeline:run-e2e-omnibus-once label
started a merge train
mentioned in commit fccfe6e5
added workflowstaging-canary label and removed workflowproduction label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!3354 (merged)
added releasedpublished label and removed releasedcandidate label