Diff image view spacing
What does this MR do and why?
Diff image: Change spacing to align visually better with the rest of the content (vertical adjustment)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Go to an MR with an image, add a diff comment to the image
- Check the spacing in the Overview/Changes tabs
Related to #469616 (closed)
Merge request reports
Activity
changed milestone to %17.4
assigned to @seggenberger
added devopsfoundations label
- Resolved by Phil Hughes
requested review from @annabeldunstone
added sectioncore platform label and removed sectiondev label
added pipelinetier-1 label
Reviewer roulette
Category Reviewer Maintainer frontend @viktomas
(UTC+2, same timezone as author)
@pburdette
(UTC-4, 6 hours behind author)
UX @jmiocene
(UTC+2, same timezone as author)
Maintainer review is optional for UX Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 12ce0cdd and ac995bbd
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.34 MB 4.34 MB - 0.0 % mainChunk 3.27 MB 3.27 MB - 0.0 %
Note: We do not have exact data for 12ce0cdd. So we have used data from: 84b635e6.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangerremoved review request for @annabeldunstone
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for ac995bbdexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 128 | 0 | 16 | 0 | 144 | ✅ | | Govern | 72 | 0 | 0 | 0 | 72 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 20 | 0 | 12 | 0 | 32 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Plan | 73 | 0 | 0 | 0 | 73 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Secure | 3 | 0 | 0 | 0 | 3 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 389 | 0 | 32 | 0 | 421 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Phil Hughes
Hey @iamphill do you mind maintainerize this one? TY!
requested review from @iamphill
cc @mle
added 1 commit
- ac995bbd - Diff image: Change spacing used to better align with content
requested review from @iamphill
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
added this merge request to the merge train at position 2
mentioned in commit 1c14e968
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label