Skip to content

E2E test: remove view_merge_requests_spec.rb from quarantine

Jay McCure requested to merge jmc-remove-quarantine-mr-invalid-url into master

What does this MR do and why?

Resolves #426722 (closed)

This spec was quarantined as per #426722 (closed).

Note: not adding :blocking or :smoke so if this fails it won't block anything. We have a bot that will auto-create an MR to promote to blocking once it is deemed reliable.

Passing against staging: https://ops.gitlab.net/gitlab-org/quality/staging/-/jobs/15247348#L457

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

bundle exec rspec qa/specs/features/api/3_create/merge_request/view_merge_requests_spec.rb (note: this test will fail if you have the http router enabled on your GDK -> following up here: #471172 (comment 2091101376) )

We expect a 400 for each of the following:

curl -I --cookie "gitlab_canary=true" 'https://gitlab.com/-/merge_requests?sort=created_date&state=<th:t=\"%24{dfb}%23foreach'
curl -I 'https://gitlab.com/-/merge_requests?sort=created_date&state=<th:t=\"%24{dfb}%23foreach'
curl -I --cookie "gitlab_canary=true" 'https://staging.gitlab.com/-/merge_requests?sort=created_date&state=<th:t=\"%24{dfb}%23foreach'
curl -I 'https://staging.gitlab.com/-/merge_requests?sort=created_date&state=<th:t=\"%24{dfb}%23foreach'
Edited by Jay McCure

Merge request reports