Update Work Item Drawer header
What does this MR do and why?
Updates the header section of the Work Item Drawer following the guidance and designs in #465823 (closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Enable the work item drawer using the
issues_list_drawer
feature flag - Enable work item epics and the work item epic list using the
work_item_epics
,namespace_level_work_items
,work_item_epics_rollout
, andwork_item_epics_list
feature flags - Visit the epics list in a group
- Click an epic -> the drawer should appear
- Check the header section matches the requirements in #465823 (closed)
Merge request reports
Activity
changed milestone to %17.4
added automation:ml wrong devopsplan sectiondev labels
assigned to @jachapman
removed automation:ml wrong label
added docs-only label
removed docs-only label
added UX docs-only frontend work items labels
removed docs-only label
2 Warnings This merge request contains lines with testid selectors. Please ensure e2e:test-on-omnibus
job is run.This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:app/assets/javascripts/vue_shared/issuable/list/components/issuable_item.vue
2 Messages This merge request includes changes to Vue files that have both CE and EE versions. CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Vue
<template>
in CE and EESome Vue files in CE have a counterpart in EE. (For example,
path/to/file.vue
andee/path/to/file.vue
.)When run in the context of CE, the
<template>
of the CE Vue file is used. When run in the context of EE, the<template>
of the EE Vue file is used.It's easy to accidentally make a change to a CE
<template>
that should appear in both CE and EE without making the change in both places. When this happens, the change only takes effect in CE.The following Vue files were changed as part of this merge request that include both a CE and EE version of the file:
app/assets/javascripts/issues/list/components/issues_list_app.vue
If you made a change to the
<template>
of any of these Vue files that should be visible in both CE and EE, please ensure you have made your change to both versions of the file.A better alternative
An even better alternative is to refactor this component to only use a single template for both CE and EE. More info on this approach here: https://docs.gitlab.com/ee/development/ee_features.html#template-tag
testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/assets/javascripts/work_items/components/work_item_drawer.vue
+ data-testid="work-item-drawer-copy-button" + data-testid="work-item-drawer-link-button"
If the
e2e:test-on-omnibus
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:test-on-omnibus-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @agulina
(UTC+2, 1 hour ahead of author)
@ohoral
(UTC+2, 1 hour ahead of author)
UX No reviewer available Maintainer review is optional for UX Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded groupproject management label
added pipelinetier-1 label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 12ce0cdd and 4aa3de1a
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.34 MB 4.34 MB - 0.0 % mainChunk 3.27 MB 3.27 MB - 0.0 %
Note: We do not have exact data for 12ce0cdd. So we have used data from: 84b635e6.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Natalia Tepluhina
@ramistry would you be able to take a look at the frontend on this please?
@nickbrandt here's another small update on the work item drawer for a UX review when you have a moment.
requested review from @ramistry and @nickbrandt
added groupproduct planning label and removed groupproject management label
added 2 commits
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
removed review request for @nickbrandt
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 4aa3de1aexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 73 | 0 | 0 | 0 | 73 | ✅ | | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Create | 128 | 0 | 16 | 0 | 144 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Govern | 72 | 0 | 0 | 0 | 72 | ✅ | | Package | 20 | 0 | 12 | 0 | 32 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Secure | 3 | 0 | 0 | 0 | 3 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 389 | 0 | 32 | 0 | 421 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-omnibus:
test report for 4aa3de1aexpand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Plan | 82 | 0 | 9 | 0 | 91 | ✅ | | Create | 408 | 0 | 51 | 0 | 459 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 490 | 0 | 60 | 0 | 550 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
- Resolved by Rajan Mistry
- Resolved by Natalia Tepluhina
removed review request for @ramistry
requested review from @ntepluhina
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #7764690487 ee/spec/features/groups/work_items/work_item_spec.rb#L46
Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 65.12 s < 50.13 s - A deleted user
added rspec:slow test detected label
removed pipeline:run-e2e-omnibus-once label
started a merge train
mentioned in commit 7638957a
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#8309 (closed)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label