Skip to content
Snippets Groups Projects

Add default background color to timeline avatars

Merged Sascha Eggenberger requested to merge timeline-avatars-add-default-bg-v2 into master
All threads resolved!

What does this MR do and why?

Add default background color to timeline avatars

If a transparent gif or png is used the timeline line is leaking into the image.

This is a follow-up to !164234 (comment 2080819247) as it got reverted because we forgot to add the border-radius.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
before after

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Related to #469616 (closed)

Closes #377342 (closed)

Edited by Sascha Eggenberger

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • requested changes

  • added 27 commits

    Compare with previous version

  • requested review from @annabeldunstone

  • Annabel Dunstone Gray approved this merge request

    approved this merge request

  • removed review request for @annabeldunstone

  • requested review from @anna_vovchenko

  • Anna Vovchenko
  • requested review from @anna_vovchenko

  • Anna Vovchenko approved this merge request

    approved this merge request

  • Anna Vovchenko resolved all threads

    resolved all threads

  • Anna Vovchenko enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Anna Vovchenko added this merge request to the merge train at position 2

    added this merge request to the merge train at position 2

  • Anna Vovchenko mentioned in commit e9866344

    mentioned in commit e9866344

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading