Add default background color to timeline avatars
What does this MR do and why?
Add default background color to timeline avatars
If a transparent gif or png is used the timeline line is leaking into the image.
This is a follow-up to !164234 (comment 2080819247) as it got reverted because we forgot to add the border-radius.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Related to #469616 (closed)
Closes #377342 (closed)
Merge request reports
Activity
changed milestone to %17.4
assigned to @seggenberger
- Resolved by Anna Vovchenko
requested review from @danmh
added devopsfoundations groupux paper cuts sectioncore platform labels
requested review from @annabeldunstone
added pipelinetier-1 label
mentioned in merge request !164234 (merged)
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Category Reviewer Maintainer frontend @rcrespo3
(UTC-4, 6 hours behind author)
@aturinske
(UTC-7, 9 hours behind author)
UX @jmiocene
(UTC+2, same timezone as author)
Maintainer review is optional for UX Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Sascha Eggenberger
issue:
steps to reproduce
- Create an MR that adds an image to a repo
- Reply to a thread using the start a review option
- Add to review a comment to the image
note: this also looks to cause a scroll bar cause of the border, but I think out of scope
Edited by Dan MH
- Resolved by Annabel Dunstone GrayEdited by Dan MH
added 1 commit
- 01b53a7f - Add default background color to timeline avatars
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 5684838c and 43deed0c
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.34 MB 4.34 MB - -0.0 % mainChunk 3.27 MB 3.27 MB - -0.0 %
Note: We do not have exact data for 5684838c. So we have used data from: 76ade3e2.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 43deed0cexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 128 | 0 | 16 | 0 | 144 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 73 | 0 | 0 | 0 | 73 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Govern | 72 | 0 | 0 | 0 | 72 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Package | 20 | 0 | 12 | 0 | 32 | ✅ | | Secure | 3 | 0 | 0 | 0 | 3 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 389 | 0 | 32 | 0 | 421 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
removed review request for @annabeldunstone
requested review from @annabeldunstone
added UX UX Paper Cuts maintenancerefactor sectiondev typemaintenance labels and removed sectioncore platform typebug labels
added bugux typebug labels and removed typemaintenance label
removed maintenancerefactor label
- Resolved by Annabel Dunstone Gray
added 27 commits
-
01b53a7f...ece16cf8 - 26 commits from branch
master
- 43deed0c - Add default background color to timeline avatars
-
01b53a7f...ece16cf8 - 26 commits from branch
requested review from @annabeldunstone
removed review request for @annabeldunstone
requested review from @anna_vovchenko
- Resolved by Anna Vovchenko
Hey @anna_vovchenko can you maintainerize this small fix? TY!
- Resolved by Anna Vovchenko
requested review from @anna_vovchenko
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
added this merge request to the merge train at position 2
mentioned in commit e9866344
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!3354 (merged)
added releasedpublished label and removed releasedcandidate label