Skip to content
Snippets Groups Projects

Lint issue in gitaly

Merged Archish Thakkar requested to merge gitlab-community/gitlab:482413-gitaly into master
All threads resolved!
  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA

What does this MR do and why?

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Related to #482413

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jaime Martinez
  • Jaime Martinez
  • Jaime Martinez requested changes

    requested changes

  • Archish Thakkar requested review from @jaime

    requested review from @jaime

  • added 1 commit

    • 99f0bd51 - Handled lint fixes & package comments

    Compare with previous version

  • Jaime Martinez mentioned in issue #496666

    mentioned in issue #496666

  • Archish Thakkar added 1053 commits

    added 1053 commits

    • 99f0bd51...3db8cb33 - 1051 commits from branch gitlab-org:master
    • 7da26e0f - Merge branch 'master' of gitlab.com:gitlab-community/gitlab into 482413-gitaly
    • 7bbb30fb - Updated comment

    Compare with previous version

  • Archish Thakkar requested review from @jaime

    requested review from @jaime

  • Jaime Martinez changed milestone to %17.5

    changed milestone to %17.5

  • added 1 commit

    Compare with previous version

  • @archish27 good stuff here, LGTM! :rocket:

    @nolith can you please do the maintainer review? :green_heart:

  • Jaime Martinez requested review from @nolith

    requested review from @nolith

  • Jaime Martinez approved this merge request

    approved this merge request

  • added pipelinetier-2 label and removed pipelinetier-1 label

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • Reviewer roulette

    Category Reviewer Maintainer
    workhorse @jaime profile link current availability (UTC+10) @igor.drozdov profile link current availability (UTC+2)

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Alessio Caiazza approved this merge request

    approved this merge request

  • Alessio Caiazza resolved all threads

    resolved all threads

  • Thankyou very much @archish27 :green_heart:

    I'm starting a pipelinetier-3 and set auto-merge :rocket:

  • Alessio Caiazza enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • @archish27, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

    1. React with a :thumbsup: or a :thumbsdown: on this comment to describe your experience.
    2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

    Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.

    Thanks for your help! :heart:

    This message was generated automatically. You're welcome to improve it.

  • mentioned in commit 0c0e54ad

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading