Skip to content

Recover deprecation behavior for current rails version

Bogdan Denkovych requested to merge recover-deprecation-behavior-for-current-rails-version into master

What does this MR do and why?

Rails 7.1 slightly changed API to configure its deprecation behavior(https://github.com/rails/rails/pull/46049). We started using new API to configure deprecation behavior for GitLab environments running on the next rails version in !162085 (merged). However, we changed the deprecation behavior for the current rails version. It even lead to a flaky test #478094 (closed).

This MR recovers deprecation behavior for the current rails version.

This MR also removes new-ignored_warnings-deprecation-behavior introduced by !162085 (merged). If we have a choice, I would suggest considering and implementing ignored_warnings by a separate MR if we really need this. Ignoring warnings my not be a good idea.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Bogdan Denkovych

Merge request reports