Draft: Enable downloading of a specific report
4 unresolved threads
Closed
requested to merge gitlab-community/gitlab:enable-downloading-of-a-specific-report into master
4 unresolved threads
What does this MR do and why?
Job Artifact API endpoints do not work for report artifacts -#352644
Artifacts download REST API doesn't work for reports unless they are also listed under artifacts - #426810
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
assigned to @oksanakohuch-ext
added pipelinetier-1 label
- A deleted user
added backend label
190 Warnings 
This MR has a Changelog commit for EE, but no code changes in ee/. Consider removing theEE: truetrailer from your commits.16e9ee8f: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 8baf9c16: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. c700a576: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 332d19b8: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 0a3226a6: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. fb0d5a5e: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 2e50ba57: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. cab0fea2: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 71e34356: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 782677e0: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 2db57d7d: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 725deb0e: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 510b3c00: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 5f1901d3: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 800200ee: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. f4b16875: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. ad8e3b50: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. c3942496: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 0866ef7f: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 6ee40750: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. f76faed0: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 5f49606b: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. ed256e12: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 4c5d0ac2: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 15eb6afe: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 1d9212f7: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. e9291833: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 396e4a25: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 6927b319: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 7980673c: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 81826baf: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 0130a312: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. cfde235e: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 057db507: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 634a9262: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. ecf7e4f5: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 81bbb0d5: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 9807fb0f: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 0a9bd412: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. aea18273: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. aea18273: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 71ea1772: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 892b0b38: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 892b0b38: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 1278d0aa: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 6ef0e661: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. fbcbd59d: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. de105815: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. efae6734: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 713f7782: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. c52ce9d3: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. e2966e9e: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. a4ecf5d4: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. c8341270: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 5b1a4395: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. eeb0598b: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 7e569cc2: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. b1f5a55a: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. bb87177e: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 3afb5bb4: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. a5f477e1: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. a37d795f: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 33f75660: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. f92e2fc4: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. af483428: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. aeb336a4: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. f146d9f2: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 276106cf: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 4583d724: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. f1913022: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. a23cbcbb: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 583adb28: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 83b8a650: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 725797ba: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 93c69a2b: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. f53c2668: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1798d3fb: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. e8c6d201: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. cdc23a26: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. c605c6a0: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 2cb80a94: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 187a6aa8: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 70a0fb87: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 170a80a9: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 7ef0907f: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. 7ef0907f: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. bd71457a: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 849e2394: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 2f711419: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 3ceb7998: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 851b426b: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 60a081ad: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 32ed70ef: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 98e0ef27: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 2743d238: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. e9d05ffe: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. e4299596: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. 3d3e03da: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 9344c4dd: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. f5c2a454: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. fc4e3fb5: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. fdcdd81b: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 7427f68c: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 1e6df776: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 92d07cf7: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. dd1e0800: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 44e2470e: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 67bc0124: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. e06d654f: The commit subject and body must be separated by a blank line. For more information, take a look at our Commit message guidelines. e06d654f: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 831021cc: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 411b91ac: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. d131d5a8: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. 0d45d41d: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 2ab2de8a: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. b35d9a61: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. 9a7bd21d: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. e561fc6d: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. cec22ad6: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. c81e21b2: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. a3461331: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 0a5f7cb5: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. fada2e9a: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. 2cfc07d6: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. bcad90db: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 34d07eda: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 0ebf9cd8: Use full URLs instead of short references ( gitlab-org/gitlab#123or!123), as short references are displayed as plain text outside of GitLab. For more information, take a look at our Commit message guidelines.28736549: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 366b21a9: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. c0c9187b: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. c21c6da6: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 27703c5f: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 490e3b77: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. 4e262cc9: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 36a6434d: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. cc9a5426: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 82cf41d8: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 20a01a2a: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 3d498b84: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 59a49e63: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. 7594e056: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 79bf2517: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. 9d552dd7: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. a5010b58: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 4ab8bcf1: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 5fe8fbe9: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. ca100167: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. daafaa37: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 018d7d89: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. c58c6f80: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. 107ef519: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. 48f65233: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. 3ab876aa: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 9de5fa84: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. f9f96d71: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. e8cbafe9: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 2488a611: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 9b16a867: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. e8ea4a72: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. 93bc531f: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 36bd456e: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. f23d0827: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 475cdbaa: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 8fd743ea: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. dd0b73b6: The commit subject must not end with a period. For more information, take a look at our Commit message guidelines. f4cdb128: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. c5b89276: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 86f71825: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. e2599809: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. cc05650d: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. e24e34f6: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. e24e34f6: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 49008fcd: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. 49008fcd: The commit subject must not end with a period. For more information, take a look at our Commit message guidelines. c2fd7c6b: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 18b68427: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 23fb4221: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 75725856: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 2d4d02c7: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. e27cb70d: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. bb896747: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. a5720ce7: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. a5080639: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 7f4fb3e8: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. This merge request has more than 20 commits which may cause issues in some of the jobs. If you see errors like missing commits, please consider squashing some commits so it is within 20 commits. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
There were no new or modified feature flag YAML files detected in this MR. If the changes here are already controlled under an existing feature flag, please add
the feature flagexists. Otherwise, if you think the changes here don't need
to be under a feature flag, please add the label feature flagskipped, and
add a short comment about why we skipped the feature flag.For guidance on when to use a feature flag, please see the documentation.
This merge request does not refer to an existing milestone. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, maintenanceperformance, documentation, QA labels.Reviewer roulette
Category Reviewer Maintainer backend @marcogreg(UTC+8, 8 hours ahead of author)
@hustewart(UTC-5, 5 hours behind author)
~"Verify" Reviewer review is optional for ~"Verify" @drew(UTC+0, same timezone as author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
added grouppipeline execution label
added devopsverify sectionci labels
added featureaddition typefeature labels
@oksanakohuch-ext - can you please advise if this MR is ready for review or still needs further work?
added Contractor Contribution label
mentioned in issue #480866 (closed)
added customer label
added 8934 commits
-
44c9fbee...740901c9 - 8933 commits from branch
gitlab-org:master - 59f869ff - Merge branch gitlab:master into enable-downloading-of-a-specific-report
-
44c9fbee...740901c9 - 8933 commits from branch
4 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
There were no new or modified feature flag YAML files detected in this MR. If the changes here are already controlled under an existing feature flag, please add
the feature flagexists. Otherwise, if you think the changes here don't need
to be under a feature flag, please add the label feature flagskipped, and
add a short comment about why we skipped the feature flag.For guidance on when to use a feature flag, please see the documentation.
This merge request does not refer to an existing milestone. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.1 Message 
CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelogtrailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @marcogreg@hustewart~"Verify" Reviewer review is optional for ~"Verify" @drewPlease refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
added 12247 commits
-
59f869ff...c4456f31 - 12246 commits from branch
gitlab-org:master - 0a632d80 - Merge branch gitlab:master into enable-downloading-of-a-specific-report
-
59f869ff...c4456f31 - 12246 commits from branch
151 desc 'Download a specific report from artifacts archive' do 152 failure [ 153 { code: 400, message: 'Bad request' }, 154 { code: 401, message: 'Unauthorized' }, 155 { code: 403, message: 'Forbidden' }, 156 { code: 404, message: 'Not found' } 157 ] 158 end 159 params do 160 requires :job_id, type: Integer, desc: 'The ID of a job' 161 requires :report_type, type: String, desc: 'Type of downloadable report .' 162 optional :job_token, type: String, 163 desc: 'To be used with triggers for multi-project pipelines, ' \ 164 'available only on Premium and Ultimate tiers.' 165 end 166 route_setting :authentication, job_token_allowed: true An AppSec review is recommended for changes related to CI JOB TOKEN.
This AppSec automation is currently under testing. Use appsec-sasthelpful or appsec-sastunhelpful for quick feedback. To stop the bot from further commenting, you can use the appsec-saststop label. For any detailed feedback, add a comment here.
added feature flagskipped label
requested review from @drew
@oksanakohuch-ext I have the regular amount of hesitation about adding a new endpoint
I'm not saying I'm certain we should do that instead, but it's definitely something we should consider before we commit to a new endpoint.
mentioned in issue #504176
Please register or sign in to reply