Add config file parser for Java Gradle `build.gradle`
What does this MR do and why?
Background
The Repository X-Ray is a tool that searches for dependency manager configuration files (aka "lock files") and then extracts a list of libraries from the content.
In #474306 (comment 2025085630), we decided to migrate the Repository X-Ray functionality into the GitLab Rails monolith. This gives us two main benefits: (i) it will eventually allow us to run the service outside of the CI pipeline, and (ii) we can maintain the parsing logic centrally so that other domains can utilize it.
Base MR
In !162313 (merged), we introduced the ConfigFiles::Base
class where the intention is for each dependency manager config file type to be represented by a child class. The child class contains the parsing logic to extract a list of libraries and their versions from the file content.
This MR
In this MR, we introduce the JavaGradle
config file class that parses build.gradle
.
Also applied a minor change to config_file_shared_examples.rb
to ignore array order for libs
.
Resolves part of #476177 (closed).
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #476177 (closed)
Merge request reports
Activity
changed milestone to %17.4
assigned to @lma-git
mentioned in issue #476177 (closed)
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @syarynovskyi
(UTC+3, 10 hours ahead of author)
@pskorupa
(UTC+2, 9 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Leaminn Ma
mentioned in issue #481317
- Resolved by Leaminn Ma
Hi @emeraldjayde! Could you please give this a first backend review? If it looks okay, please forward it to maintainer review. Thanks!
requested review from @emeraldjayde
added pipeline:mr-approved label
added pipelinetier-2 label
@mikolaj_wawrzyniak can we get a maintainer review please?
Edited by Emerald-Jayde Henaorequested review from @mikolaj_wawrzyniak
added 1 commit
- 2c79b407 - Minor refactor of shared_example to ignore libs order
- Resolved by Leaminn Ma
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 50884a82expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Plan | 73 | 0 | 0 | 0 | 73 | ✅ | | Govern | 72 | 0 | 0 | 0 | 72 | ✅ | | Create | 128 | 0 | 16 | 0 | 144 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 20 | 0 | 12 | 0 | 32 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Secure | 3 | 0 | 0 | 0 | 3 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 389 | 0 | 32 | 0 | 421 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-omnibus:
test report for 50884a82expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Create | 557 | 0 | 68 | 0 | 625 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 557 | 0 | 68 | 0 | 625 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
- Resolved by Mikołaj Wawrzyniak
- Resolved by Mikołaj Wawrzyniak
- Resolved by Leaminn Ma
- Resolved by Mikołaj Wawrzyniak
- Resolved by Mikołaj Wawrzyniak
- Resolved by Mikołaj Wawrzyniak
- Resolved by Leaminn Ma
Thank you @lma-git I left some points for your consideration, please take a look
added 1456 commits
-
2c79b407...b0104d8f - 1453 commits from branch
master
- 1d382f0f - Add Java Gradle config file class
- e68a424c - Minor refactor of shared_example to ignore libs order
- 50884a82 - Apply suggestions to logic
Toggle commit list-
2c79b407...b0104d8f - 1453 commits from branch
requested review from @mikolaj_wawrzyniak
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
removed pipeline:run-e2e-omnibus-once label
started a merge train
mentioned in commit 9fe2f915
mentioned in merge request !165260 (merged)
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label