Avatar: Refactor to use gl-avatar
What does this MR do and why?
Avatar: Refactor to use gl-avatar
Replaces instances of .avatar with .gl-avatar and removes old CSS.
- Replaces old .avatar instances with GlAvatar or .gl-avatar
- Removes non compliant 40px sizes with 32px
- Removes unused CSS
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
Visual changes | |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
No visual changes | |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Group: http://gdk.test:3000/flightjs
- Project: http://gdk.test:3000/flightjs/Flight
- Issue: http://gdk.test:3000/flightjs/Flight/-/issues/38
- MR: http://gdk.test:3000/flightjs/Flight/-/merge_requests/4
- MR Commits: http://gdk.test:3000/flightjs/Flight/-/merge_requests/4/commits
- Billing: http://gdk.test:3000/-/profile/billings
- Issue boards: http://gdk.test:3000/groups/flightjs/-/boards/3?assignee_username=arie.wyman
- User profile: http://gdk.test:3000/users/root/activity
- Commit: http://gdk.test:3000/flightjs/Flight/-/commit/6e399a0205f2446b6702d36d61ad3ff7e2bff3ee
- Job: http://gdk.test:3000/flightjs/Flight/-/jobs/863
Related to #469616 (closed)
Merge request reports
Activity
assigned to @seggenberger
added devopsfoundations label
added pipelinetier-1 label
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger
- A deleted user
added backend label
3 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.This merge request changed files with disabled eslint rules. Please consider fixing them. This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:app/assets/javascripts/vue_shared/alert_details/components/sidebar/sidebar_assignees.vue
1 Message This merge request includes changes to Vue files that have both CE and EE versions. Vue
<template>
in CE and EESome Vue files in CE have a counterpart in EE. (For example,
path/to/file.vue
andee/path/to/file.vue
.)When run in the context of CE, the
<template>
of the CE Vue file is used. When run in the context of EE, the<template>
of the EE Vue file is used.It's easy to accidentally make a change to a CE
<template>
that should appear in both CE and EE without making the change in both places. When this happens, the change only takes effect in CE.The following Vue files were changed as part of this merge request that include both a CE and EE version of the file:
app/assets/javascripts/boards/components/board_list_header.vue
If you made a change to the
<template>
of any of these Vue files that should be visible in both CE and EE, please ensure you have made your change to both versions of the file.A better alternative
An even better alternative is to refactor this component to only use a single template for both CE and EE. More info on this approach here: https://docs.gitlab.com/ee/development/ee_features.html#template-tag
Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/diffs/components/commit_item.vue
app/assets/javascripts/users_select/index.js
spec/frontend/gfm_auto_complete_spec.js
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/diffs/components/commit_item.vue' \ 'app/assets/javascripts/users_select/index.js' \ 'spec/frontend/gfm_auto_complete_spec.js'
Reviewer roulette
Category Reviewer Maintainer backend @ivaneG
(UTC+1, 1 hour behind author)
@a_akgun
(UTC+3, 1 hour ahead of author)
frontend @jachapman
(UTC+1, 1 hour behind author)
@ntepluhina
(UTC+2, same timezone as author)
UX @paintedbicycle-gitlab
(UTC+0, 2 hours behind author)
Maintainer review is optional for UX Application Security Reviewer review is optional for Application Security @ngeorge1
(UTC+1, 1 hour behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
Tailwind CSS
Interpolated utils
The following files might contain interpolated utils:
app/helpers/avatars_helper.rb
app/helpers/projects_helper.rb
spec/helpers/avatars_helper_spec.rb
If you are leveraging CSS utilities, make sure they are written in full and not built via string interpolation as that would prevent Tailwind CSS from generating them.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerremoved backend label
added pipeline:skip-pajamas-adoption label
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger
- A deleted user
added backend label
- Resolved by Anna Vovchenko
requested review from @annabeldunstone
added 61 commits
-
55904ae3...32210c49 - 60 commits from branch
master
- 6570a374 - Avatar: Refactor to use gl-avatar
-
55904ae3...32210c49 - 60 commits from branch
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits b0104d8f and b1067154
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.33 MB 4.33 MB - 0.0 % mainChunk 3.27 MB 3.27 MB - 0.0 %
Note: We do not have exact data for b0104d8f. So we have used data from: 2249c6cd.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangerrequested review from @annabeldunstone
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger
removed review request for @annabeldunstone
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger
added 52 commits
-
045d4d89...606bc3db - 51 commits from branch
master
- 2502cbf7 - Avatar: Refactor to use gl-avatar
-
045d4d89...606bc3db - 51 commits from branch
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #7668431864 spec/features/admin/users/users_spec.rb#L177
Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 66.3 s < 50.13 s #7718374550 spec/features/admin/users/users_spec.rb#L177
Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 66.59 s < 50.13 s #7718828442 spec/features/admin/users/users_spec.rb#L177
Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 65.73 s < 50.13 s #7720021656 spec/features/admin/users/users_spec.rb#L177
Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 65.85 s < 50.13 s #7721762080 spec/features/admin/users/users_spec.rb#L177
Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 66.56 s < 50.13 s #7725880290 spec/features/admin/users/users_spec.rb#L177
Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 65.4 s < 50.13 s #7727032338 spec/features/admin/users/users_spec.rb#L177
Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 65.69 s < 50.13 s #7729181372 spec/features/admin/users/users_spec.rb#L177
Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 66.03 s < 50.13 s #7742334507 spec/features/admin/users/users_spec.rb#L177
Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 66.07 s < 50.13 s #7744062595 spec/features/admin/users/users_spec.rb#L177
Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 65.89 s < 50.13 s #7745693559 spec/features/admin/users/users_spec.rb#L177
Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 65.7 s < 50.13 s #7745904547 spec/features/admin/users/users_spec.rb#L177
Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 66.25 s < 50.13 s - A deleted user
added rspec:slow test detected label
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for b1067154expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 72 | 0 | 0 | 0 | 72 | ✅ | | Secure | 3 | 0 | 0 | 0 | 3 | ✅ | | Plan | 73 | 0 | 0 | 0 | 73 | ✅ | | Create | 128 | 0 | 16 | 0 | 144 | ✅ | | Package | 19 | 0 | 13 | 0 | 32 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 388 | 0 | 33 | 0 | 421 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+