Disable Sidekiq worker open transaction check in JS specs

What does this MR do and why?

When transactional tests are enabled, Rails ensures that all threads use the same connection for accessing the database. However this may cause a false positive with the Sidekiq worker open transaction check because:

1. A browser may have multiple requests in-flight.
2. A transaction may start in the middle of another request. For example, an update to a merge request column initiates a transaction via SAVEPOINT.

To avoid false positives, disable this check for JavaScript feature specs run. The alternative is to use the deletion strategy, but that would significantly slow tests.

Relates to #478601 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

Repeatedly run:

bundle exec rspec ./spec/features/merge_request/user_squashes_merge_request_spec.rb

assigned to @stanhu

added devopscreate groupsource code sectiondev labels

added pipelinetier-1 label

added backend label

	1 Warning
	8decab7a: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.

Reviewer roulette

Category	Reviewer	Maintainer
backend	@OmarQunsulGitlab (UTC+2, 9 hours ahead of author)	@hmehra (UTC+10, 17 hours ahead of author)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added Category:Source Code Management label

Proper labels assigned to this merge request. Please ignore me.

@stanhu - please see the following guidance and update this merge request.

	1 Error
	Please add typebug typefeature, or typemaintenance label to this merge request.

added 1 commit

• 34976639 - Disable Sidekiq worker open transaction check in JS specs

Compare with previous version

added 1 commit

• e6fb01fe - Disable Sidekiq worker open transaction check in JS specs

Compare with previous version

changed milestone to %17.4

requested review from @OmarQunsulGitlab

changed the description

added maintenancepipelines typemaintenance labels and removed Category:Source Code Management backend devopscreate groupsource code pipelinetier-1 sectiondev labels

added devopscreate groupsource code sectiondev labels

resolved all threads

Doh, this was not enough to fix the issue.

removed review request for @OmarQunsulGitlab

added Category:Source Code Management label

added 1 commit

• f96cfeee - Disable Sidekiq worker open transaction check in JS specs

Compare with previous version

added 1 commit

• 8decab7a - Disable Sidekiq worker open transaction check in JS specs

Compare with previous version

requested review from @OmarQunsulGitlab

added backend label

approved this merge request

added pipeline:mr-approved label

added pipelinetier-3 pipeline:run-e2e-omnibus-once labels

requested review from @reprazent

removed review request for @OmarQunsulGitlab

approved this merge request

enabled automatic add to merge train when checks pass

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 8decab7a

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Plan        | 73     | 0      | 0       | 0     | 73    | ✅     |
| Create      | 128    | 0      | 15      | 0     | 143   | ✅     |
| Verify      | 44     | 0      | 2       | 0     | 46    | ✅     |
| Govern      | 71     | 0      | 0       | 0     | 71    | ✅     |
| Package     | 20     | 0      | 12      | 0     | 32    | ✅     |
| Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
| Data Stores | 31     | 0      | 1       | 0     | 32    | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Secure      | 3      | 0      | 0       | 0     | 3     | ✅     |
| Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
| Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 388    | 0      | 31      | 0     | 419   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for 8decab7a

expand test summary

+-------------------------------------------------------------+
|                       suites summary                        |
+--------+--------+--------+---------+-------+-------+--------+
|        | passed | failed | skipped | flaky | total | result |
+--------+--------+--------+---------+-------+-------+--------+
| Create | 417    | 0      | 51      | 0     | 468   | ✅     |
+--------+--------+--------+---------+-------+-------+--------+
| Total  | 417    | 0      | 51      | 0     | 468   | ✅     |
+--------+--------+--------+---------+-------+-------+--------+

removed pipeline:run-e2e-omnibus-once label

started a merge train

merged

mentioned in commit a90c07cf

mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#8114 (closed)

mentioned in issue #478601 (closed)

mentioned in merge request !162803 (merged)

added workflowstaging-canary label

added workflowcanary label and removed workflowstaging-canary label

mentioned in merge request !164022 (merged)

mentioned in issue #457549 (closed)

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label

mentioned in merge request !167702 (closed)

mentioned in merge request !176874 (merged)