Skip to content
Snippets Groups Projects

Cleanup chat history before sending it to LLM in V2 agent

Merged Tetiana Chupryna requested to merge 478619-clean-chat-history-v2 into master
All threads resolved!

What does this MR do and why?

Fix for Gracefully handle null content in Duo Chat history (#478619 - closed) it also contains backported deduplication history functionality

Original code: cleanup and deduplication

Note: this is a fix for a bug for a feature that is still behind a feature flag

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

How to set up and validate locally

  1. Turn on the feature flag v2_chat_agent_integration
  2. Open chat and ask it different questions.
  3. Open new tab and observe chat history

Related to #478619 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 1 Warning
    :warning: The master pipeline status page reported failures in

    If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
    Please check for any on-going incidents in the incident issue tracker or in the #master-broken Slack channel.

    1 Message
    :book: CHANGELOG missing:

    If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Category Reviewer Maintainer
    backend @bucoleary profile link current availability (UTC-4, 6 hours behind author) @vshushlin profile link current availability (UTC+2, same timezone as author)

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Lesley Razzaghian approved this merge request

    approved this merge request

  • @brytannia Looks good to me!

    @seanarnold I was wondering if you can do the backend maintainer review. Thank you!

  • requested review from @seanarnold

  • Lesley Razzaghian removed review request for @seanarnold

    removed review request for @seanarnold

  • added pipelinetier-2 label and removed pipelinetier-1 label

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • requested review from @seanarnold

  • Lesley Razzaghian removed review request for @lesley-r

    removed review request for @lesley-r

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 426ed285

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Verify      | 44     | 0      | 2       | 0     | 46    | ✅     |
    | Plan        | 74     | 0      | 1       | 0     | 75    | ✅     |
    | Data Stores | 31     | 0      | 1       | 0     | 32    | ✅     |
    | Create      | 128    | 0      | 16      | 0     | 144   | ✅     |
    | Package     | 20     | 0      | 12      | 0     | 32    | ✅     |
    | Govern      | 72     | 0      | 0       | 0     | 72    | ✅     |
    | Secure      | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 391    | 0      | 33      | 0     | 424   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Sean Arnold
  • added 1 commit

    • d0f92c37 - Clarify on confusing messages/conversations

    Compare with previous version

  • Sean Arnold approved this merge request

    approved this merge request

  • Sean Arnold resolved all threads

    resolved all threads

  • Sean Arnold enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Sean Arnold aborted automatic add to merge train because the source branch was updated. Learn more.

    aborted automatic add to merge train because the source branch was updated. Learn more.

  • Sean Arnold added 2870 commits

    added 2870 commits

    Compare with previous version

  • Sean Arnold enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • @tigerwnz I rebased this now can't approve - do you mind approving?

  • Tiger Watson approved this merge request

    approved this merge request

  • merged

  • Sean Arnold mentioned in commit e1b11e1f

    mentioned in commit e1b11e1f

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading