Skip to content
Snippets Groups Projects

Fixes `Sidekiq.strict_args` warning

Open Bojan Marjanovic requested to merge bmarjanovic/fix-sidekiq-strict-args into master
All threads resolved!

What does this MR do and why?

This MR fixes the Sidekiq's warning message:

Job arguments to Users::TrackNamespaceVisitsWorker must be native JSON types, but Fri, 23 Aug 2024 14:39:29 +0200 is a DateTime.
See https://github.com/sidekiq/sidekiq/wiki/Best-Practices
To disable this error, add `Sidekiq.strict_args!(false)` to your initializer.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

N/A

How to set up and validate locally

  1. Checkout the branch
  2. Verify there is no warning message anymore :tada:

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Reviewer roulette

    Category Reviewer Maintainer
    backend @missy-gitlab profile link current availability (UTC-4, 6 hours behind author) @sashi_kumar profile link current availability (UTC+0, 2 hours behind author)

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Allen Cook approved this merge request

    approved this merge request

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • Allen Cook resolved all threads

    resolved all threads

  • Allen Cook enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • :tools: Generated by gitlab_quality-test_tooling.


    :snail: Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

    Click to expand
    Job File Name Duration Expected duration
    #7655314746 spec/features/admin/users/users_spec.rb#L177 Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 66.91 s < 50.13 s
    #7655312108 spec/features/admin/users/users_spec.rb#L177 Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 70.96 s < 50.13 s
  • A deleted user added rspec:slow test detected label
  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for d7bf474d

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 73     | 0      | 0       | 0     | 73    | ✅     |
    | Package     | 20     | 0      | 12      | 0     | 32    | ✅     |
    | Create      | 128    | 0      | 15      | 0     | 143   | ✅     |
    | Govern      | 71     | 0      | 0       | 0     | 71    | ✅     |
    | Verify      | 44     | 0      | 2       | 0     | 46    | ✅     |
    | Data Stores | 31     | 0      | 1       | 0     | 32    | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Secure      | 3      | 0      | 0       | 0     | 3     | ✅     |
    | Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 388    | 0      | 31      | 0     | 419   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Allen Cook added this merge request to the merge train at position 2

    added this merge request to the merge train at position 2

  • merged

  • Allen Cook mentioned in commit aa6d02a9

    mentioned in commit aa6d02a9

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading