Skip to content

Update order of click modifiers

What does this MR do and why?

Update order of click modifiers

  • the "native" modifier cannot go before the "capture" modifier in vue/compat
  • otherwise the jest tests will not register a click

Changelog: changed

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
access_dropdown No change

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Tests

  1. Run yarn jest spec/frontend/groups/settings/components/access_dropdown_spec.js and verify all the tests pass
  2. Run VUE_VERSION=3 yarn jest spec/frontend/groups/settings/components/access_dropdown_spec.js and verify all the tests pass
  3. Same for other tests

UI

  1. Note: this is an EE feature, you'll need a license to verify it locally
  2. Validate the project-level view works as expected:
    • Visit Project -> Settings -> CI/CD
    • Select Protected environments section
    • Verify the settings: you should be able to select an environment, the list of deployers and approvers (could be roles, related groups, or users), save / edit / unprotect an environment.
  3. Validate the group-level view works as expected:
    • Visit Group -> Settings -> CI/CD
    • Select Protected environments section
    • Verify the settings: you should be able to select an environment tier, the list of deployer groups, and save / edit / unprotect an environment.
  4. Same for other dropdowns

Related to #480074 (closed)

Edited by Alexander Turinske

Merge request reports

Loading