Refactor draft notes CSS
What does this MR do and why?
- Renames
draft_note.scss
-->draft_note_v2.scss
(which will be reverted after all the comments/notes have bene refactored) - Moves draft styles into file
- Removes styles from
notes.scss
- Use utility classes when possible
Follow up to Rewrite system note CSS (!162639 - merged) and Use new CSS file for work items system notes (!163663 - merged)
(see more details in #469616 (closed))
Note The UI/screenshots are slightly different. In some cases the alignment has been improved (changed description), in others it's slightly of (system notes within diffs). In an effort to not nest styles too much I'd prefer to rely on the utility classes until we're further along in this effort.
Screenshots or screen recordings
Overview tab
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
Changes tab
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Create pending comments on MR, check both overview and changes tabs
Links
Merge request reports
Activity
changed milestone to %17.4
added UX UX Paper Cuts frontend maintenanceusability typemaintenance labels
assigned to @annabeldunstone
added pipelinetier-1 label
2 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.a43f4509: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. Reviewer roulette
Category Reviewer Maintainer frontend @jrushford
(UTC+2, 2 hours ahead of author)
@sdejonge
(UTC+10, 10 hours ahead of author)
test for spec/features/*
@rliu-gl
(UTC-4, 4 hours behind author)
Maintainer review is optional for test for spec/features/*
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits b657246e and a43f4509
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.31 MB 4.31 MB - 0.0 % mainChunk 3.27 MB 3.27 MB - 0.0 %
Note: We do not have exact data for b657246e. So we have used data from: 1a3dc66e.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 35 commits
-
430cbf38...04cea761 - 34 commits from branch
master
- 596e07ef - Refactor draft notes CSS
-
430cbf38...04cea761 - 34 commits from branch
added 187 commits
-
596e07ef...7a88a66d - 186 commits from branch
master
- 17090b52 - Refactor draft notes CSS
-
596e07ef...7a88a66d - 186 commits from branch
- Resolved by Annabel Dunstone Gray
@seggenberger Can you please review UX here?
requested review from @seggenberger
mentioned in issue #469616 (closed)
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
removed review request for @seggenberger
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for a43f4509expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Plan | 73 | 0 | 0 | 0 | 73 | ✅ | | Create | 128 | 0 | 15 | 0 | 143 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Govern | 70 | 1 | 0 | 0 | 71 | ❌ | | Package | 20 | 0 | 12 | 0 | 32 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Secure | 3 | 0 | 0 | 0 | 3 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 387 | 1 | 31 | 0 | 419 | ❌ | +-------------+--------+--------+---------+-------+-------+--------+
added 182 commits
-
f543a779...1fc24041 - 181 commits from branch
master
- 7989c0b3 - Refactor draft notes CSS
-
f543a779...1fc24041 - 181 commits from branch
- Resolved by Annabel Dunstone Gray
@iamphill Could you please review for frontend and groupcode review?
Background: we're working on cleaning up notes CSS as much as possible (more details in #469616 (closed)).
requested review from @iamphill
- Resolved by Annabel Dunstone Gray
- Resolved by Annabel Dunstone Gray
added 172 commits
-
fba005c8...9c22b928 - 171 commits from branch
master
- 6c743a6a - Refactor draft notes CSS
-
fba005c8...9c22b928 - 171 commits from branch
requested review from @iamphill
@iamphill Could youp lease take another look?
added 242 commits
-
6c743a6a...8e7a4d2e - 240 commits from branch
master
- cbeb5a9d - Refactor draft notes CSS
- a43f4509 - Remove -v2 from draft notes
-
6c743a6a...8e7a4d2e - 240 commits from branch
@iamphill Back to you
requested review from @iamphill
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
started a merge train
mentioned in commit eb1df521
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#8147 (closed)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in merge request !164339 (merged)
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!3354 (merged)
added releasedpublished label and removed releasedcandidate label