Skip to content

Add additional parameter to ListConfigVariablesService reactive cache

Furkan Ayhan requested to merge 468827-NEW-optimize-ListConfigVariablesService-1 into master

What does this MR do and why?

History

!162055 (merged) was reverted because we saw inconsistent behaviors in Staging. The reason is that we can't change the parameters of calculate_reactive_cache in a single release, just like Sidekiq workers. (because they are actually working as Sidekiq workers)

Now

This is the first step of optimizing Ci::ListConfigVariablesService.

Changing parameters in an calculate_reactive_cache method is like changing parameters in a Sidekiq worker. So, we need to follow the same rules;

  1. Add the argument to the worker with a default value (Release M).
  2. Add the new argument to all the invocations of the worker (Release M+1).
  3. Remove the default value (Release M+2).

Related to #468827

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Furkan Ayhan

Merge request reports