Skip to content
Snippets Groups Projects

Clarify configure SAST with customizations docs

Merged Adam Cohen requested to merge clarify-configure-sast-with-customizations-docs into master
All threads resolved!

What does this MR do and why?

While investigating https://gitlab.com/gitlab-com/sec-sub-department/section-sec-request-for-help/-/issues/357+s, I consulted the Configure SAST with customizations docs and noticed that they're incorrect.

The docs currently explain:

1. If the project does not have a `.gitlab-ci.yml` file, select **Enable SAST** in the Static
   Application Security Testing (SAST) row, otherwise select **Configure SAST**.

These docs indicate that if a .gitlab-ci.yml file is present, the button will show Configure SAST, however, this is not the case. In order for the button to show Configure SAST "[the latest] pipeline must have been successfully executed and generated valid artifacts" for the SAST scanner to be considered enabled, as explained in Fix text about Ultimate features and clarify co... (!100015 - merged) • Sam White • 15.5.

This MR clarifies the condition required for the button to show Enable SAST or Configure SAST.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
Screenshot_2024-08-22_at_2.17.11_PM Screenshot_2024-08-22_at_2.19.07_PM
Edited by Adam Cohen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sam White requested changes

    requested changes

  • Adam Cohen resolved all threads

    resolved all threads

  • Adam Cohen requested review from @rdickenson

    requested review from @rdickenson

  • Adam Cohen requested review from @sam.white

    requested review from @sam.white

  • Adam Cohen added 1 commit

    added 1 commit

    • 47b503fa - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Russell Dickenson resolved all threads

    resolved all threads

  • Russell Dickenson approved this merge request

    approved this merge request

  • Russell Dickenson bypassed reviews on this merge request

    bypassed reviews on this merge request

  • mentioned in commit edd6facd

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading