Add required approval for Duo Chat
What does this MR do and why?
Currently, we're migrating Duo Chat to a new agent which means that ZeroShot::Executor and related classes will be removed and we need to be careful introducing new tools. To ensure that we don't add any changes that can cause disruption of Duo Chat team work, I want to introduce required approval for certain files:
- ee/lib/gitlab/llm/chain/agents/zero_shot/ - All this folder will be removed. We need to catch all situations when somebody adds changes there and prevents it. From now on, new features should be added to
SingleActionExecutor
. Read more in this issue - ee/lib/gitlab/llm/chain/agents/single_action_executor.rb - New v2 chat agent, approval for this file is needed more to keep the Chat team informed about the changes.
- ee/lib/gitlab/llm/chain/streamed_zero_shot_answer.rb - Related to ZeroShot and will be removed.
- ee/lib/gitlab/llm/completions/chat.rb - Contains the list of chat tools. When we move to v2 chat agent, before we solve how to version the Chat prompt we want to make sure that nobody adds new tools there. It will cause inconsistency in behaviour for different AI GW clients. Read more in this issue.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
N/A
How to set up and validate locally
N/A
Merge request reports
Activity
added Category:Duo Chat backend groupduo chat maintenanceworkflow meta labels
assigned to @brytannia
requested review from @igor.drozdov
changed milestone to %17.4
added devopsai-powered sectiondata-science labels
added typemaintenance label
added pipelinetier-1 label
- Resolved by Igor Drozdov
@igor.drozdov could you please merge this change?
UPD: sorry, I realized that this MRs need approval of code owners, not BE maintainers.
Edited by Tetiana Chupryna
requested review from @sean_carroll and removed review request for @igor.drozdov
Reviewer roulette
Category Reviewer Maintainer .gitlab/CODEOWNERS
Reviewer review is optional for .gitlab/CODEOWNERS
@dianalogan
(UTC+1, 1 hour behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
started a merge train
mentioned in commit 5e6a65e2
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label