Skip to content

Add required approval for Duo Chat

Tetiana Chupryna requested to merge brytannia-master-patch-b6e8 into master

What does this MR do and why?

Currently, we're migrating Duo Chat to a new agent which means that ZeroShot::Executor and related classes will be removed and we need to be careful introducing new tools. To ensure that we don't add any changes that can cause disruption of Duo Chat team work, I want to introduce required approval for certain files:

  • ee/lib/gitlab/llm/chain/agents/zero_shot/ - All this folder will be removed. We need to catch all situations when somebody adds changes there and prevents it. From now on, new features should be added to SingleActionExecutor. Read more in this issue
  • ee/lib/gitlab/llm/chain/agents/single_action_executor.rb - New v2 chat agent, approval for this file is needed more to keep the Chat team informed about the changes.
  • ee/lib/gitlab/llm/chain/streamed_zero_shot_answer.rb - Related to ZeroShot and will be removed.
  • ee/lib/gitlab/llm/completions/chat.rb - Contains the list of chat tools. When we move to v2 chat agent, before we solve how to version the Chat prompt we want to make sure that nobody adds new tools there. It will cause inconsistency in behaviour for different AI GW clients. Read more in this issue.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

N/A

How to set up and validate locally

N/A

Merge request reports