Check current user is nil when serialising
What does this MR do?
https://sentry.gitlab.net/gitlab/staginggitlabcom/issues/942845/?query=is:unresolved
We don't have current_user in following objects at the moment
CompareDependencyScanningReportsService
CompareContainerScanningReportsService
CompareSastReportsService These services expose data using Vulnerabilities::OccurrenceEntity and Vulnerabilities::FeedbackEntity which is used by other objects to expose data. However, these object don't have current_user at the moment and it is causing issue like this
https://sentry.gitlab.net/gitlab/staginggitlabcom/issues/942845/?query=is:unresolved
This MR solves this problem by safe operating on current_user we something like this in Vulnerabilities::OccurrenceEntity already
Longer work is addressed here however we have to merge this MR regardless of other work. There could be some vulnerabilities without issues or feedback. (i.e. vulnerabilities that are going to be introduced with New MR)
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/16252
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team