Remove nil content from Duo Chat message history

marked this merge request as draft

changed title from Remove nil content from Duo Chat messages" to Draft: Remove nil content from Duo Chat messages

added pipelinetier-1 label

added backend label

1 Message

CHANGELOG missing:

If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Category	Reviewer	Maintainer
backend	`@atiwari71` (UTC+5.5)	`@marc_shaw` (UTC+2)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

removed backend label

changed the description

changed title from Draft: Remove nil content from Duo Chat messages to Draft: Remove nil content from Duo Chat message history

Proper labels assigned to this merge request. Please ignore me.

@lesley-r - please see the following guidance and update this merge request.

	1 Error
	Please add typebug typefeature, or typemaintenance label to this merge request.

@brytannia I think you were planning something similar to deduplicate_roles on the v2 endpoint

If you don't mind, maybe you can add this piece in as well.

changed the description

added typebug label

resolved all threads

marked this merge request as ready

requested review from @nateweinshenker

Hi @nateweinshenker

I was wondering if you can review

Thank you!

@lesley-r

Looked around for our tools and I didn't see anywhere where we default to passing nil content through the assistant conversational role. Slightly confusing how we got that message, but looks good for helping to prevent that duplicate process.

approved this merge request

LGTM. Can you assign someone in a closer timezone to give another check? My GDK seems to be stuck when trying to test that Gitlab Duo Chat is working.

added pipeline:mr-approved label

added pipelinetier-2 label and removed pipelinetier-1 label

Before you set this MR to auto-merge

This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

Before you set this MR to auto-merge, please check the following:

You are the last maintainer of this merge request
The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
This pipeline is recent enough (created in the last 8 hours)

If all the criteria above apply, please set auto-merge for this merge request.

See pipeline tiers and merging a merge request for more details.

added backend label

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for ca65dd95

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Plan        | 73     | 0      | 0       | 0     | 73    | ✅     |
| Create      | 128    | 0      | 15      | 0     | 143   | ✅     |
| Govern      | 71     | 0      | 0       | 0     | 71    | ✅     |
| Package     | 20     | 0      | 12      | 0     | 32    | ✅     |
| Verify      | 44     | 0      | 2       | 0     | 46    | ✅     |
| Data Stores | 31     | 0      | 1       | 0     | 32    | ✅     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
| Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
| Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Secure      | 3      | 0      | 0       | 0     | 3     | ✅     |
| Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 388    | 0      | 31      | 0     | 419   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+