Simplify specs for Project#disabled_services
What does this MR do?
Adding new specs to cover disabled project services with other price tiers will be easier now.
This came up during https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/16117.
RSpec output
Project
#disabled_services
license_feature: :jenkins_integration, disabled_services: ["jenkins", "jenkins_deprecated"]
when feature is available
should not include "jenkins" and "jenkins_deprecated"
when feature is unavailable
should include "jenkins" and "jenkins_deprecated"
license_feature: :github_project_service_integration, disabled_services: ["github"]
when feature is available
should not include "github"
when feature is unavailable
should include "github"
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen