Add Go Modules lock file class
What does this MR do and why?
Background
The Repository X-Ray is a tool that searches for dependency manager configuration files (aka "lock files") and then extracts a list of libraries from the content.
In #474306 (comment 2025085630), we decided to migrate the Repository X-Ray functionality into the GitLab Rails monolith. This gives us two main benefits: (i) it will eventually allow us to run the service outside of the CI pipeline, and (ii) we can maintain the parsing logic centrally so that other domains can utilize it.
Base MR
In !162313 (merged), we introduced the LockFiles::Base
class where the intention is for each lock file type to be represented by a child class. The child class is to contain the parsing logic to extract a list of libraries and their versions from the file content.
This MR
In this MR, we introduce the GoModules
lock file class that parses go.mod
.
Resolves part of #476177 (closed).
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #476177 (closed)
Merge request reports
Activity
changed milestone to %17.4
assigned to @lma-git
mentioned in issue #476177 (closed)
added 704 commits
-
034588d3...a04d6782 - 703 commits from branch
master
- 34df8aa9 - Add Go Modules lock file class
-
034588d3...a04d6782 - 703 commits from branch
- Resolved by Gosia Ksionek
Hi @emeraldjayde! Could you please give this MR a first review?
requested review from @emeraldjayde
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @schmil.monderer
(UTC+3, 10 hours ahead of author)
@grzesiek
(UTC+2, 9 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Gosia Ksionek
- Resolved by Gosia Ksionek
- Resolved by Gosia Ksionek
tiny comments!
requested review from @emeraldjayde
added pipeline:mr-approved label
added pipelinetier-2 label
Hi @mksionek, can you please review?
requested review from @mksionek
removed review request for @emeraldjayde
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
removed pipelinetier-3 label
added pipelinetier-3 label
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 34df8aa9expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 71 | 0 | 0 | 0 | 71 | ✅ | | Plan | 73 | 0 | 0 | 0 | 73 | ✅ | | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Create | 128 | 0 | 15 | 0 | 143 | ✅ | | Package | 20 | 0 | 12 | 0 | 32 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Secure | 3 | 0 | 0 | 0 | 3 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 388 | 0 | 31 | 0 | 419 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 34df8aa9expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Create | 417 | 0 | 51 | 0 | 468 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 417 | 0 | 51 | 0 | 468 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
removed pipeline:run-e2e-omnibus-once label
started a merge train
mentioned in commit 54cbf4eb
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label