Fix icon and alignment of weight widget in sidebar when locked
What does this MR do and why?
When weight is a locked feature, the icon and alignment are wrong for the weight widget in a collapsed issue sidebar.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Check out this branch
- apply this patch in the GDK to make the sidebar render the locked version of the weight widget:
diff --git a/ee/app/views/shared/issuable/_sidebar_weight.html.haml b/ee/app/views/shared/issuable/_sidebar_weight.html.haml
index 566a43e882ae..df34c3ab7b62 100644
--- a/ee/app/views/shared/issuable/_sidebar_weight.html.haml
+++ b/ee/app/views/shared/issuable/_sidebar_weight.html.haml
@@ -1,5 +1,5 @@
- if issuable_sidebar[:supports_weight]
- if issuable_sidebar[:features_available][:issue_weights]
- .js-sidebar-weight-widget-root{ data: { can_edit: can_edit, project_path: project_path, issue_iid: issue_iid } }
- - else
= render 'shared/promotions/promote_issue_weights'
+ - else
+ .js-sidebar-weight-widget-root{ data: { can_edit: can_edit, project_path: project_path, issue_iid: issue_iid } }
- Visit an issue and collapse the issue sidebar
- You will see that the widget matches the others in layout and scale, and uses the correct weight icon. The text will read
None
instead ofNo
.
Related to #469616 (closed)
Merge request reports
Activity
added UX Paper Cuts bugux groupproject management labels
assigned to @clavimoniere
changed milestone to %17.4
added devopsfoundations sectioncore platform labels
added devopsplan sectiondev labels and removed devopsfoundations sectioncore platform labels
added devopsfoundations sectioncore platform labels and removed devopsplan sectiondev labels
added typebug label
added pipelinetier-1 label
added devopsplan sectiondev labels and removed devopsfoundations sectioncore platform labels
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Category Reviewer Maintainer backend @jfypk
(UTC+0, 4 hours ahead of author)
@maddievn
(UTC+2, 6 hours ahead of author)
frontend @jrushford
(UTC+2, 6 hours ahead of author)
@aturinske
(UTC-6, 2 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger@aturinske can we skip straight to a frontend maintainer review on this?
requested review from @aturinske
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 3fab94daexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 73 | 0 | 0 | 0 | 73 | ✅ | | Create | 128 | 0 | 15 | 0 | 143 | ✅ | | Govern | 71 | 0 | 0 | 0 | 71 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 20 | 0 | 12 | 0 | 32 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Secure | 3 | 0 | 0 | 0 | 3 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 388 | 0 | 31 | 0 | 419 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 3fab94daexpand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Plan | 82 | 0 | 9 | 0 | 91 | ✅ | | Create | 270 | 0 | 34 | 0 | 304 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 352 | 0 | 43 | 0 | 395 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
removed pipeline:run-e2e-omnibus-once label
started a merge train
removed this merge request from the merge train because the pipeline did not succeed. Learn more.
started a merge train
mentioned in commit 32f4765f
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!3354 (merged)
added releasedpublished label and removed releasedcandidate label