Unifies the sidebar width for work items and border color
What does this MR do and why?
Unifies the sidebar width for work items and border color across different content types (work items, MR, issuables, project overview)
- Changes width of work items to match other parts of our UI (MRs, Project overview)
- Uses
subtle
border (migrates to use design tokens)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
Work items | |
![]() |
![]() |
MR | |
![]() |
![]() |
Project overview | |
![]() |
![]() |
Issuables | |
![]() |
![]() |
How to set up and validate locally
- Enable FF for new work-item related Epics (see https://docs.gitlab.com/ee/user/group/epics/epic_work_items.html)
- Epic/Work item: e.g. http://gdk.test:3000/groups/flightjs/-/epics/5
- MR: e.g. http://gdk.test:3000/flightjs/Flight/-/merge_requests/13
- Project overview: e.g. http://gdk.test:3000/flightjs/Flight
- Issuable: e.g. http://gdk.test:3000/flightjs/Flight/-/issues/38
Related to #469616 (closed)
Merge request reports
Activity
changed milestone to %17.4
assigned to @seggenberger
added devopsfoundations groupux paper cuts sectioncore platform labels
added UX UX Paper Cuts frontend maintenancerefactor sectiondev typemaintenance labels and removed sectioncore platform label
added pipelinetier-1 label
- Resolved by Sascha Eggenberger
Hey @annabeldunstone
Would you mind having a look here? I'm not sure yet if we should use the
subtle
ordefault
border color variant. WDYT?
requested review from @annabeldunstone
- Resolved by Sascha Eggenberger
Also FYI @nickbrandt @nickleonard @mle
2 Warnings 83b12ec6: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. This merge request contains lines with testid selectors. Please ensure e2e:test-on-omnibus
job is run.testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/assets/javascripts/work_items/components/work_item_development/work_item_development.vue
- data-testid="dev-widget-label" - data-testid="more-information" + data-testid="dev-widget-label" - data-testid="add-item" - <gl-button category="secondary" size="small" data-testid="create-mr-button">{{ - <gl-button category="tertiary" size="small" data-testid="create-branch-button">{{ + data-testid="more-information" + data-testid="add-item" + <gl-button category="secondary" size="small" data-testid="create-mr-button">{{ + <gl-button category="tertiary" size="small" data-testid="create-branch-button">{{
app/assets/javascripts/work_items/components/work_item_due_date.vue
- <section class="gl-pb-4" data-testid="work-item-start-due-dates"> + <section data-testid="work-item-start-due-dates">
ee/app/assets/javascripts/work_items/components/work_item_rolledup_dates.vue
- <section class="gl-pb-4" data-testid="work-item-rolledup-dates"> + <section data-testid="work-item-rolledup-dates">
If the
e2e:test-on-omnibus
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:test-on-omnibus-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @marina.mosti
(UTC+2, same timezone as author)
@f_caplette
(UTC-4, 6 hours behind author)
UX @nickbrandt
(UTC-6, 8 hours behind author)
Maintainer review is optional for UX Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 2f9aa6a9 and 83b12ec6
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.33 MB 4.33 MB - -0.0 % mainChunk 3.27 MB 3.27 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Sascha Eggenberger
added 1 commit
- 81294112 - Unifies the sidebar width for work items and border color
- Resolved by Michael Le
- Resolved by Annabel Dunstone Gray
@seggenberger Small bug with the overflow
Current this branch
added 1 commit
- 44941b0f - Unifies the sidebar width for work items and border color
added 1 commit
- b9a68759 - Unifies the sidebar width for work items and border color
mentioned in issue #463598 (closed)
removed review request for @annabeldunstone
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
requested review from @nickbrandt
added 471 commits
-
b9a68759...1622588a - 470 commits from branch
master
- 8c708548 - Unifies the sidebar width for work items and border color
-
b9a68759...1622588a - 470 commits from branch
added groupproduct planning label and removed groupux paper cuts label
added 191 commits
-
8c708548...160dbbff - 190 commits from branch
master
- 6e80b516 - Unifies the sidebar width for work items and border color
-
8c708548...160dbbff - 190 commits from branch
added 1 commit
- df8fe77c - Unifies the sidebar width for work items and border color
added 1 commit
- 2a0221b3 - Unifies the sidebar width for work items and border color
- Resolved by Alex Pennells
Hey @apennells can you have a look at frontend here?
Also I'm struggling a bit to see why this pipeline is failing, you might see why right away
requested review from @apennells
mentioned in issue #479609 (closed)
removed review request for @nickbrandt
added 222 commits
-
2a0221b3...33eccebe - 221 commits from branch
master
- 9d40433b - Unifies the sidebar width for work items and border color
-
2a0221b3...33eccebe - 221 commits from branch
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 83b12ec6expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 128 | 0 | 15 | 0 | 143 | ✅ | | Plan | 73 | 0 | 0 | 0 | 73 | ✅ | | Govern | 71 | 0 | 0 | 0 | 71 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Package | 20 | 0 | 12 | 0 | 32 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Secure | 3 | 0 | 0 | 0 | 3 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 388 | 0 | 31 | 0 | 419 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
added 1 commit
- cc1d80fd - Unifies the sidebar width for work items and border color
- Resolved by Alex Pennells
added 555 commits
-
cc1d80fd...8f1a9437 - 554 commits from branch
master
- 57925491 - Unifies the sidebar width for work items and border color
-
cc1d80fd...8f1a9437 - 554 commits from branch
added 1 commit
- 4e513232 - Unifies the sidebar width for work items and border color
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #7650880052 ee/spec/features/groups/work_items/work_item_spec.rb#L46
Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 52.49 s < 50.13 s #7668274159 ee/spec/features/groups/work_items/work_item_spec.rb#L46
Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 57.06 s < 50.13 s #7708562215 ee/spec/features/groups/work_items/work_item_spec.rb#L46
Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 53.09 s < 50.13 s - A deleted user
added rspec:slow test detected label
requested review from @apennells
added 1 commit
- f41dfdf3 - Unifies the sidebar width for work items and border color
added 295 commits
-
f41dfdf3...606bc3db - 294 commits from branch
master
- 7061066a - Unifies the sidebar width for work items and border color
-
f41dfdf3...606bc3db - 294 commits from branch
added 1 commit
- 83eb2082 - Unifies the sidebar width for work items and border color
added 1 commit
- 543f83db - Unifies the sidebar width for work items and border color
added 1 commit
- 83b12ec6 - Unifies the sidebar width for work items and border color