Skip to content
Snippets Groups Projects

Unifies the sidebar width for work items and border color

Merged Sascha Eggenberger requested to merge unify-sidebar-width-and-borders into master

What does this MR do and why?

Unifies the sidebar width for work items and border color across different content types (work items, MR, issuables, project overview)

  • Changes width of work items to match other parts of our UI (MRs, Project overview)
  • Uses subtle border (migrates to use design tokens)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
Work items
epic_before epic_after
MR
mr_before mr_after
Project overview
project_before project_after
Issuables
issuable_before issuable_after

How to set up and validate locally

  1. Enable FF for new work-item related Epics (see https://docs.gitlab.com/ee/user/group/epics/epic_work_items.html)
  2. Epic/Work item: e.g. http://gdk.test:3000/groups/flightjs/-/epics/5
  3. MR: e.g. http://gdk.test:3000/flightjs/Flight/-/merge_requests/13
  4. Project overview: e.g. http://gdk.test:3000/flightjs/Flight
  5. Issuable: e.g. http://gdk.test:3000/flightjs/Flight/-/issues/38

Related to #469616 (closed)

Edited by Sascha Eggenberger

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 81294112 - Unifies the sidebar width for work items and border color

    Compare with previous version

  • Michael Le
  • added 1 commit

    • 44941b0f - Unifies the sidebar width for work items and border color

    Compare with previous version

  • added 1 commit

    • b9a68759 - Unifies the sidebar width for work items and border color

    Compare with previous version

  • mentioned in issue #463598 (closed)

  • Annabel Dunstone Gray approved this merge request

    approved this merge request

  • removed review request for @annabeldunstone

  • added pipelinetier-2 label and removed pipelinetier-1 label

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • requested review from @nickbrandt

  • Sascha Eggenberger added 471 commits

    added 471 commits

    Compare with previous version

  • Sascha Eggenberger marked this merge request as ready

    marked this merge request as ready

  • Sascha Eggenberger added 191 commits

    added 191 commits

    Compare with previous version

  • added 1 commit

    • df8fe77c - Unifies the sidebar width for work items and border color

    Compare with previous version

  • added 1 commit

    • 2a0221b3 - Unifies the sidebar width for work items and border color

    Compare with previous version

  • requested review from @apennells

  • mentioned in issue #479609 (closed)

  • Sascha Eggenberger removed review request for @nickbrandt

    removed review request for @nickbrandt

  • Sascha Eggenberger resolved all threads

    resolved all threads

  • Sascha Eggenberger added 222 commits

    added 222 commits

    Compare with previous version

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 83b12ec6

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 128    | 0      | 15      | 0     | 143   | ✅     |
    | Plan        | 73     | 0      | 0       | 0     | 73    | ✅     |
    | Govern      | 71     | 0      | 0       | 0     | 71    | ✅     |
    | Data Stores | 31     | 0      | 1       | 0     | 32    | ✅     |
    | Verify      | 44     | 0      | 2       | 0     | 46    | ✅     |
    | Package     | 20     | 0      | 12      | 0     | 32    | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Secure      | 3      | 0      | 0       | 0     | 3     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 388    | 0      | 31      | 0     | 419   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • added 1 commit

    • cc1d80fd - Unifies the sidebar width for work items and border color

    Compare with previous version

  • Sascha Eggenberger added 555 commits

    added 555 commits

    Compare with previous version

  • added 1 commit

    • 4e513232 - Unifies the sidebar width for work items and border color

    Compare with previous version

  • :tools: Generated by gitlab_quality-test_tooling.


    :snail: Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

    Click to expand
    Job File Name Duration Expected duration
    #7650880052 ee/spec/features/groups/work_items/work_item_spec.rb#L46 Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 52.49 s < 50.13 s
    #7668274159 ee/spec/features/groups/work_items/work_item_spec.rb#L46 Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 57.06 s < 50.13 s
    #7708562215 ee/spec/features/groups/work_items/work_item_spec.rb#L46 Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 53.09 s < 50.13 s
  • A deleted user added rspec:slow test detected label
  • requested review from @apennells

  • added 1 commit

    • f41dfdf3 - Unifies the sidebar width for work items and border color

    Compare with previous version

  • Sascha Eggenberger added 295 commits

    added 295 commits

    Compare with previous version

  • added 1 commit

    • 83eb2082 - Unifies the sidebar width for work items and border color

    Compare with previous version

  • added 1 commit

    • 543f83db - Unifies the sidebar width for work items and border color

    Compare with previous version

  • added 1 commit

    • 83b12ec6 - Unifies the sidebar width for work items and border color

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading