Omit extra nginx enablement in ref arch
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA
What does this MR do?
Nginx is enabled by default (based on code and testing) in reference architecture for Rails servers, no need to manually enable it
Related issues
Author's checklist
-
Optional. Consider taking the GitLab Technical Writing Fundamentals course. -
Follow the: -
If you're adding a new page, add the product availability details under the H1 topic title. -
If you are a GitLab team member, request a review based on: - The documentation page's metadata.
- The associated Technical Writer.
If you are a GitLab team member and only adding documentation, do not add any of the following labels:
~"frontend"
~"backend"
~"type::bug"
~"database"
These labels cause the MR to be added to code verification QA issues.
Reviewer's checklist
Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.
If you aren't sure which tech writer to ask, use roulette or ask in the #docs Slack channel.
-
If the content requires it, ensure the information is reviewed by a subject matter expert. - Technical writer review items:
-
Ensure docs metadata is present and up-to-date. -
Ensure the appropriate labels are added to this MR. -
Ensure a release milestone is set. - If relevant to this MR, ensure content topic type principles are in use, including:
-
The headings should be something you'd do a Google search for. Instead of Default behavior
, say something likeDefault behavior when you close an issue
. -
The headings (other than the page title) should be active. Instead of Configuring GDK
, say something likeConfigure GDK
. -
Any task steps should be written as a numbered list. - If the content still needs to be edited for topic types, you can create a follow-up issue with the docs-technical-debt label.
-
-
-
Review by assigned maintainer, who can always request/require the reviews above. Maintainer's review can occur before or after a technical writer review.
Merge request reports
Activity
assigned to @bbodenmiller
added Leading Organization label
Thanks for your contribution to GitLab @bbodenmiller!
Did you know about our community forks? Working from there will make your contribution process easier. Please check it out!
- If you need help, comment
@gitlab-bot help
or come say hi on Discord. - When you're ready for a review, comment on this merge request with
@gitlab-bot ready
. - Tip: Start @gitlab-bot commands at the beginning of a new comment and do not wrap the command in quotes or backticks.
- We welcome AI-generated contributions! Read more/check the box at the top of the merge request description.
- To add labels to your merge request, comment
@gitlab-bot label ~"label1" ~"label2"
.
This message was generated automatically. You're welcome to improve it.
- If you need help, comment
added Community contribution workflowin dev labels
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/administration/reference_architectures/10k_users.md
(Link to current live version) -
doc/administration/reference_architectures/25k_users.md
(Link to current live version) -
doc/administration/reference_architectures/2k_users.md
(Link to current live version) -
doc/administration/reference_architectures/3k_users.md
(Link to current live version) -
doc/administration/reference_architectures/50k_users.md
(Link to current live version) -
doc/administration/reference_architectures/5k_users.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
@gitlab-bot ready
added workflowready for review label and removed workflowin dev label
Hi
@axil
! Please review this documentation merge request. This message was generated automatically. You're welcome to improve it.added twtriaged label
requested review from @axil
@axil, this Community contribution is ready for review.
- Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
- If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
This message was generated automatically. You're welcome to improve it.
mentioned in issue gitlab-org/quality/triage-reports#19212 (closed)
- Resolved by Nailia Iskhakova
@niskhakova another one.
changed milestone to %17.4
requested review from @niskhakova
- Resolved by Achilleas Pipinellis
Nginx is enabled by default ..., no need to manually enable it
@bbodenmiller @axil I am wondering if this was set to be explicit, and clear that it is expected the NGINX will be present and functional?
To be clear, we should be looking to flesh out usage of the Roles of Omnibus, and linking via comments to the appropriate roles, if we can. Perhaps those can (outside of this MR) be expanded to make it more obvious precisely which components are present. Per the lines related to the change, it does seem odd that we are explicitly enabling or disabling any given component, when the Role should be addressing that.
mentioned in issue gitlab-org/quality/triage-reports#19279 (closed)
added Category:Build label
mentioned in issue omnibus-gitlab#8686
mentioned in issue omnibus-gitlab#8685
mentioned in issue gitlab-org/quality/triage-reports#19363 (closed)
removed review request for @axil
removed review request for @niskhakova
Hi @niskhakova
We noticed this MR is marked as workflowready for review but no reviewer is assigned. workflowin dev has automatically been applied to this MR based on the likelihood the review is finished. If additional reviews are still required, please assign a reviewer and reapply workflowready for review.
@bbodenmiller you may also request a review by commenting
@gitlab-bot ready
. You can also assign reviewers directly using@gitlab-bot ready @user1 @user2
if you know the relevant reviewer(s), such as those who were involved in a related issue.This message was generated automatically. You're welcome to improve it.
added workflowin dev label and removed workflowready for review label
added 3492 commits
-
a132c920...0a090c76 - 3491 commits from branch
master
- 51ecec3b - Omit extra nginx enablement in ref arch
-
a132c920...0a090c76 - 3491 commits from branch
requested review from @niskhakova and @axil
started a merge train
@bbodenmiller, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- React with a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
- React with a
mentioned in commit 44654a55
added Category:Build workflowstaging-canary labels and removed Category:Build workflowin dev labels
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label