Remove exclude_child_pipelines_from_tag_branch_query feature flag

What does this MR do and why?

Remove the exclude_child_pipelines_from_tag_branch_query feature flag.

The FF has been enabled on gprd since Aug 9th, and has been enabled on gitlab-org/gitlab since July 16th. Since we have seen no issues, it should be safe to remove this FF.

MR that introduced this FF: !145503 (merged).

#463296 (closed)

DB review artifacts

Old query

Raw SQL with branches:

SELECT
    "p_ci_pipelines".*
FROM
    (VALUES ('master'), ('17-1-stable-ee')) AS refs(ref),
    LATERAL (
        SELECT p_ci_pipelines.*
        FROM
            "p_ci_pipelines"
        WHERE
            "p_ci_pipelines"."project_id" = 278964
            AND "p_ci_pipelines"."ref" = refs.ref
        ORDER BY id DESC LIMIT 1      
    ) "p_ci_pipelines"
ORDER BY "p_ci_pipelines"."id" DESC
LIMIT 20

https://postgres.ai/console/gitlab/gitlab-production-ci/sessions/35607/commands/110274

Old SQL with tags :

SELECT
    "p_ci_pipelines".*
FROM
    (VALUES ('v17.0.0-ee'), ('v17.1.1-ee')) AS refs(ref),
    LATERAL (
        SELECT p_ci_pipelines.*
        FROM
            "p_ci_pipelines"
        WHERE
            "p_ci_pipelines"."project_id" = 278964
            AND "p_ci_pipelines"."ref" = refs.ref
        ORDER BY id DESC LIMIT 1      
    ) "p_ci_pipelines"
ORDER BY "p_ci_pipelines"."id" DESC
LIMIT 20

https://postgres.ai/console/gitlab/gitlab-production-ci/sessions/35607/commands/110271

New query

Raw SQL with branches :

SELECT
    "p_ci_pipelines".*
FROM
    (VALUES ('master'), ('17-1-stable-ee')) AS refs(ref),
    LATERAL (
        SELECT p_ci_pipelines.*
        FROM
            "p_ci_pipelines"
        WHERE
            "p_ci_pipelines"."project_id" = 278964
            AND "p_ci_pipelines"."source" != 12
            AND "p_ci_pipelines"."ref" = refs.ref
        ORDER BY id DESC LIMIT 1      
    ) "p_ci_pipelines"
ORDER BY "p_ci_pipelines"."id" DESC
LIMIT 20

https://postgres.ai/console/gitlab/gitlab-production-ci/sessions/35607/commands/110278

Raw SQL with tags:

SELECT
    "p_ci_pipelines".*
FROM
    (VALUES ('v17.0.0-ee'), ('v17.1.1-ee')) AS refs(ref),
    LATERAL (
        SELECT p_ci_pipelines.*
        FROM
            "p_ci_pipelines"
        WHERE
            "p_ci_pipelines"."project_id" = 278964
            AND "p_ci_pipelines"."source" != 12
            AND "p_ci_pipelines"."ref" = refs.ref
        ORDER BY id DESC LIMIT 1      
    ) "p_ci_pipelines"
ORDER BY "p_ci_pipelines"."id" DESC
LIMIT 20

https://postgres.ai/console/gitlab/gitlab-production-ci/sessions/35607/commands/110268

Old DB review artifacts (before https://gitlab.com/gitlab-org/gitlab/-/merge_requests/177345 was merged)

Old query

Raw SQL with branches:

SELECT
    "ci_pipelines".*
FROM
    "ci_pipelines"
WHERE
    "ci_pipelines"."project_id" = 7
    AND "ci_pipelines"."id" IN (
        SELECT
            max(id)
        FROM
            "ci_pipelines"
        WHERE
            "ci_pipelines"."project_id" = 7
            AND "ci_pipelines"."ref" IN ('''test' '', '2-mb-file')
        GROUP BY
            "ci_pipelines"."ref")
ORDER BY
    "ci_pipelines"."id" DESC

https://console.postgres.ai/gitlab/gitlab-production-ci/sessions/30972/commands/96188

Old SQL with tags :

SELECT
    "ci_pipelines".*
FROM
    "ci_pipelines"
WHERE
    "ci_pipelines"."project_id" = 9
    AND "ci_pipelines"."id" IN (
        SELECT
            max(id)
        FROM
            "ci_pipelines"
        WHERE
            "ci_pipelines"."project_id" = 9
            AND "ci_pipelines"."ref" IN ('v1.0.0', 'v1.1.0', 'v1.1.1')
        GROUP BY
            "ci_pipelines"."ref")
ORDER BY
    "ci_pipelines"."id" DESC

https://console.postgres.ai/gitlab/gitlab-production-ci/sessions/30972/commands/96191

New query

Raw SQL with branches :

SELECT
    "ci_pipelines".*
FROM
    "ci_pipelines"
WHERE
    "ci_pipelines"."project_id" = 3
    AND "ci_pipelines"."id" IN (
        SELECT
            max(id)
        FROM
            "ci_pipelines"
        WHERE
            "ci_pipelines"."project_id" = 3
            AND "ci_pipelines"."source" != 12
            AND "ci_pipelines"."ref" IN ('''test' '', '2-mb-file')
        GROUP BY
            "ci_pipelines"."ref")
ORDER BY
    "ci_pipelines"."id" DESC

https://console.postgres.ai/gitlab/gitlab-production-ci/sessions/30972/commands/96189

Raw SQL with tags:

SELECT
    "ci_pipelines".*
FROM
    "ci_pipelines"
WHERE
    "ci_pipelines"."project_id" = 278964
    AND "ci_pipelines"."id" IN (
        SELECT
            max(id)
        FROM
            "ci_pipelines"
        WHERE
            "ci_pipelines"."project_id" = 278964
            AND "ci_pipelines"."source" != 12
            AND "ci_pipelines"."ref" IN ('v17.0.0-ee', 'v17.1.1-ee')
        GROUP BY
            "ci_pipelines"."ref")
ORDER BY
    "ci_pipelines"."id" DESC

https://console.postgres.ai/gitlab/gitlab-production-ci/sessions/30972/commands/96192

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before	After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.