Skip to content

Backport 17.2 - Do not run release-environments on tagging

Dat Tangrequested to merge
cherry-pick-d6dabc6e into 17-2-stable-ee

What does this MR do and why?

Describe in detail what merge request is being backported and why

This is a backport of !162283 (merged). I quote the description here:

Do not run release-environments on tagging

Previously, we only ran release-environments with the canonical GitLab repo. Because the security MRs were only synced to canonical GitLab repo gitlab-org/gitlab after tagging, release-environments didn't run on any commit. In that situation, we need to run release-environments on tagging to validate the security MRs.

We now run release-environments on security mirror gitlab-org/security/gitlab after finishing gitlab-com/gl-infra/delivery#20285 (closed). Thus, merging happens before tagging, so all the security MRs are validated by release-environments. It is not needed to rerun release-environments once more when tagging.

This commit also avoids possible failures because the trigger build template .gitlab/ci/cng/main.gitlab-ci.yml does not support run on tagging yet.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • This MR has a severity label assigned (if applicable).
  • Set the milestone of the merge request to match the target backport branch version.
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the e2e:package-and-test-ee job has either succeeded or been approved by a Software Engineer in Test.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Merge request reports