Fix create isssue for container scanning from dashboard issue
What does this MR do?
Fixes https://gitlab.com/gitlab-org/gitlab-ee/issues/13676
Problem occurs when we try to create issue for container scanning vulnerability using security dashboard.
we use sprintf to format ticket content however sprintf doesn't work well with the HashWithIndifferentAccess
i.e
data = {"name" => "can"}
sprintf("%{name}", data} ==> this will fail
data = {name: "can"}
sprintf("%{name}", data} ==> this is okay
Screenshots
Does this MR meet the acceptance criteria?
- Import this to your local instance and run CI on master https://gitlab.com/gitlab-examples/security/security-reports/
- To go security dashboard
- Select vulnerability from container scanning
- Create issue from that vulnerability, it should create issue with no problem
- Repeat last 2 steps with DS vulnerability
- Dismiss few vulnerabilities using Sec dashboard they should work as well.
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Michael Kozono