Skip to content

Fix create isssue for container scanning from dashboard issue

Can Eldem requested to merge fix-cs-create-issue-error-ee into master

What does this MR do?

Fixes https://gitlab.com/gitlab-org/gitlab-ee/issues/13676

Problem occurs when we try to create issue for container scanning vulnerability using security dashboard.

we use sprintf to format ticket content however sprintf doesn't work well with the HashWithIndifferentAccess i.e


data = {"name" => "can"}

sprintf("%{name}", data} ==> this will fail

data = {name: "can"}

sprintf("%{name}", data} ==> this is okay

Screenshots

Screenshot_2019-09-06_at_11.17.59 Screenshot_2019-09-06_at_11.17.11

Does this MR meet the acceptance criteria?

  • Import this to your local instance and run CI on master https://gitlab.com/gitlab-examples/security/security-reports/
  • To go security dashboard
  • Select vulnerability from container scanning
  • Create issue from that vulnerability, it should create issue with no problem
  • Repeat last 2 steps with DS vulnerability
  • Dismiss few vulnerabilities using Sec dashboard they should work as well.

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Michael Kozono

Merge request reports