[Feature flag] Add actor for improved_hide_heuristics
What does this MR do and why?
Add current_user
actor for Role User.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Find screenrecordings in the issue
How to set up and validate locally
-
In rails console enable the experiment fully
Feature.enable(:improved_hide_heuristics)
-
Visit the projects overview page: http://gdk.test:3000/
-
Testing the GlCollapsibleListbox: Open the dropdown 'Name'
-
Use the keyboard tab key to focus another item, which will close the dropdown again
-
Testing the GlDisclosureDropdown: Click on the button for 'Merge requests' top in the sidebar
-
Use the keyboard tab key to focus another item, which will close the dropdown again
Related to #474824 (closed)
Merge request reports
Activity
changed milestone to %17.3
assigned to @vanessaotto
added 1 commit
- b9bb2ae1 - Add actor current_user to feature flag improved_hide_heuristics
- A deleted user
added backend label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @ahegyi
(UTC+2, same timezone as author)
@stanhu
(UTC-7, 9 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerremoved feature flag label
added feature flag label
requested review from @stanhu
- Resolved by Michał Wielich
Hi @michold, in my previous MR where I add the feature flag !161192 (merged) I did not add an actor. I realized now, that I should have added one. Sorry, this is the first time for me creating a feature flag :) Could I pass this MR directly to you for a backend maintainer review please?
Edited by Vanessa Otto
Security policy violations have been resolved.
Edited by GitLab Security Botchanged milestone to %17.4
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for b9bb2ae1expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 127 | 0 | 12 | 0 | 139 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Plan | 70 | 0 | 0 | 0 | 70 | ✅ | | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Package | 16 | 0 | 15 | 0 | 31 | ✅ | | Govern | 71 | 0 | 0 | 0 | 71 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Secure | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 379 | 0 | 31 | 0 | 410 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for b9bb2ae1expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Manage | 28 | 2 | 15 | 3 | 45 | ❌ | | Create | 270 | 0 | 34 | 0 | 304 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 298 | 2 | 49 | 3 | 349 | ❌ | +--------+--------+--------+---------+-------+-------+--------+
removed pipeline:run-e2e-omnibus-once label
started a merge train
mentioned in commit 62f68b64
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label