Skip to content

Improve matching patterns in "settings_sections" Dangerfile

Thomas Hutterer requested to merge 463524-also-check-section-component into master

What does this MR do and why?

This is a small follow-up to !161020 (merged) to close #463524.

  • Now matches both SettingsBlock and SettingsSection.¹
  • Now ignores templates in admin and profiles folders. These settings aren't searchable.

¹: I forgot that we actually have two different components for this. One is "Title + Expand/Collapse", the other is "Sticky title"... Sorry for not catching this before opening the first MR 🙈

How to set up and validate locally

  • Checkout this branch, delete a searchable settings section and run lefthook run pre-push to see the new Danger output.
  • Or check !162035 (closed) as a demo MR with such a warning in the Danger comment.
Edited by Thomas Hutterer

Merge request reports