Improve matching patterns in "settings_sections" Dangerfile
What does this MR do and why?
This is a small follow-up to !161020 (merged) to close #463524 (closed).
- Now matches both
SettingsBlock
andSettingsSection
.¹ - Now ignores templates in
admin
andprofiles
folders. These settings aren't searchable.
¹: I forgot that we actually have two different components for this. One is "Title + Expand/Collapse", the other is "Sticky title"... Sorry for not catching this before opening the first MR
How to set up and validate locally
- Checkout this branch, delete a searchable settings section and run
lefthook run pre-push
to see the new Danger output. - Or check !162035 (closed) as a demo MR with such a warning in the Danger comment.
Merge request reports
Activity
changed milestone to %17.3
assigned to @thutterer
added pipelinetier-1 label
- A deleted user
added backend label
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @minahilnichols
(UTC-4, 6 hours behind author)
@dmeshcharakou
(UTC+2, same timezone as author)
~"Tooling" Reviewer review is optional for ~"Tooling" @splattael
(UTC+2, same timezone as author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Useradded 2 commits
Hi @jennli
Could you please review this small follow-up to yesterday's MR? Thanks!requested review from @jennli
mentioned in issue #463524 (closed)
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.