Skip to content
Snippets Groups Projects

Migrate branch rule details cards to crud components

Merged Annabel Dunstone Gray requested to merge branch-rule-details into master

What does this MR do and why?

  • Migrates GlCard to CrudComponent in rule details page and drawers
  • Add page header component
  • Tweak spacing

Screenshots or screen recordings

Before After
Screenshot_2024-08-06_at_4.58.34_PM Screenshot_2024-08-06_at_5.00.52_PM
Screenshot_2024-08-06_at_4.33.26_PM Screenshot_2024-08-06_at_4.33.19_PM
Screenshot_2024-08-06_at_4.33.51_PM Screenshot_2024-08-06_at_4.57.31_PM

How to set up and validate locally

  • Enable :edit_branch_rules
  • Project > Settings > Repository > Branch rules > View details (on a branch rule)

Links

Edited by Annabel Dunstone Gray

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sascha Eggenberger requested changes

    requested changes

  • added 196 commits

    Compare with previous version

  • requested review from @seggenberger

  • mentioned in merge request !161996 (merged)

  • Sascha Eggenberger approved this merge request

    approved this merge request

  • added pipelinetier-2 label and removed pipelinetier-1 label

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • Sascha Eggenberger removed review request for @seggenberger

    removed review request for @seggenberger

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 6b3507fc

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Create      | 127    | 0      | 12      | 0     | 139   | ✅     |
    | Data Stores | 31     | 0      | 1       | 0     | 32    | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Plan        | 70     | 0      | 0       | 0     | 70    | ✅     |
    | Package     | 16     | 0      | 15      | 0     | 31    | ✅     |
    | Govern      | 71     | 0      | 0       | 0     | 71    | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Verify      | 44     | 0      | 2       | 0     | 46    | ✅     |
    | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Secure      | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 378    | 0      | 31      | 0     | 409   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • added 1 commit

    • 3ad99765 - Migrate branch rule details cards to crud components

    Compare with previous version

  • added 1 commit

    • 9527d1be - Migrate branch rule details cards to crud components

    Compare with previous version

  • added 1 commit

    • 2f43ed1b - Migrate branch rule details cards to crud components

    Compare with previous version

  • requested review from @nradina

  • added 1 commit

    • 70b32d73 - Migrate branch rule details cards to crud components

    Compare with previous version

  • Nataliia Radina mentioned in merge request !158253 (merged)

    mentioned in merge request !158253 (merged)

  • Nataliia Radina
  • Nataliia Radina
  • Annabel Dunstone Gray requested review from @blabuschagne and removed review request for @nradina

    requested review from @blabuschagne and removed review request for @nradina

  • added 1 commit

    • 6b3507fc - Migrate branch rule details cards to crud components

    Compare with previous version

  • Brandon Labuschagne approved this merge request

    approved this merge request

  • Brandon Labuschagne enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Brandon Labuschagne resolved all threads

    resolved all threads

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading