Work items child widget: Migrate to crud
What does this MR do and why?
Migrates work items widgets to the shared widget
component and removes it's own widget wrapper component.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Go to an work item, e.g. Objective
Related to #452231 (closed), #476988, !161791 (diffs)
Merge request reports
Activity
changed milestone to %17.3
assigned to @seggenberger
added devopsmanage label
added sectioncore platform label and removed sectiondev label
added pipelinetier-3 label
3 Warnings 818b93e3: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.This merge request contains lines with testid selectors. Please ensure e2e:package-and-test
job is run.testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/assets/javascripts/work_items/components/work_item_links/work_item_links.vue
- <span class="gl-new-card-count" data-testid="children-count"> - <div v-if="isChildrenEmpty && !isShownAddForm && !error" data-testid="links-empty"> - data-testid="add-links-form" - data-testid="work-item-load-more" + data-testid="add-links-form" + data-testid="work-item-load-more"
app/assets/javascripts/work_items/components/work_item_links/work_item_links_form.vue
- data-testid="add-item-form" + <gl-form data-testid="add-item-form" @submit.prevent="addOrCreateMethod"> - <div v-if="error" class="gl-mt-3 gl-text-red-500" data-testid="work-items-error"> + <div v-if="error" class="gl-mt-3 gl-text-danger" data-testid="work-items-error"> - data-testid="add-child-button" + data-testid="add-child-button"
app/assets/javascripts/work_items/components/work_item_links/work_item_tree.vue
- <div v-if="showEmptyMessage" data-testid="tree-empty"> - data-testid="add-tree-form" - data-testid="work-item-load-more" + data-testid="add-tree-form" + data-testid="work-item-load-more"
If the
e2e:package-and-test
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:package-and-test-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @drosse
(UTC+1, 1 hour behind author)
@himkp
(UTC+2, same timezone as author)
test for spec/features/*
@minahilnichols
(UTC-4, 6 hours behind author)
Maintainer review is optional for test for spec/features/*
UX @nickbrandt
(UTC-6, 8 hours behind author)
Maintainer review is optional for UX Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #7515173814 spec/features/projects/work_items/work_item_children_spec.rb#L61
Work item children for signed in user adds a new child task 72.1 s < 50.13 s #7517715458 spec/features/projects/work_items/work_item_children_spec.rb#L61
Work item children for signed in user adds a new child task 73.38 s < 50.13 s #7517576308 spec/features/projects/work_items/work_item_children_spec.rb#L61
Work item children for signed in user adds a new child task 76.66 s < 50.13 s #7524076776 spec/features/projects/work_items/work_item_children_spec.rb#L61
Work item children for signed in user adds a new child task 73.24 s < 50.13 s #7527461797 spec/features/projects/work_items/work_item_children_spec.rb#L61
Work item children for signed in user adds a new child task 75.32 s < 50.13 s #7527364429 spec/features/projects/work_items/work_item_children_spec.rb#L61
Work item children for signed in user adds a new child task 74.63 s < 50.13 s #7528551984 spec/features/projects/work_items/work_item_children_spec.rb#L61
Work item children for signed in user adds a new child task 75.91 s < 50.13 s #7532915734 spec/features/projects/work_items/work_item_children_spec.rb#L61
Work item children for signed in user adds a new child task 72.97 s < 50.13 s #7532915734 spec/features/projects/work_items/work_item_children_spec.rb#L81
Work item children for signed in user removes a child task and undoing 75.51 s < 50.13 s #7532855746 spec/features/projects/work_items/work_item_children_spec.rb#L81
Work item children for signed in user removes a child task and undoing 75.28 s < 50.13 s #7623254792 ee/spec/features/groups/work_items/work_item_spec.rb#L46
Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 51.91 s < 50.13 s #7628118938 ee/spec/features/groups/work_items/work_item_spec.rb#L46
Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 53.84 s < 50.13 s #7684223237 ee/spec/features/groups/work_items/work_item_spec.rb#L46
Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 52.42 s < 50.13 s - A deleted user
added rspec:slow test detected label
mentioned in issue #476988
added 1 commit
- 2cde625d - Work items widgets: Migrate to shared widget component
mentioned in merge request !161791 (merged)
added 75 commits
-
2cde625d...bfe3e941 - 74 commits from branch
master
- 16839fc1 - Work items widgets: Migrate to shared widget component
-
2cde625d...bfe3e941 - 74 commits from branch
added 212 commits
-
16839fc1...59f08760 - 211 commits from branch
master
- 447fc0b1 - Work items widgets: Migrate to shared widget component
-
16839fc1...59f08760 - 211 commits from branch
added 44 commits
-
447fc0b1...a699b5c9 - 43 commits from branch
master
- 4dd0dc99 - Work items widgets: Migrate to shared widget component
-
447fc0b1...a699b5c9 - 43 commits from branch
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 818b93e3expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Create | 128 | 0 | 15 | 0 | 143 | ✅ | | Package | 20 | 0 | 12 | 0 | 32 | ✅ | | Plan | 73 | 0 | 0 | 0 | 73 | ✅ | | Govern | 71 | 0 | 0 | 0 | 71 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Secure | 3 | 0 | 0 | 0 | 3 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 388 | 0 | 31 | 0 | 419 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for ebe34883expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Manage | 30 | 0 | 15 | 1 | 45 | ✅ | | Create | 270 | 0 | 34 | 0 | 304 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 300 | 0 | 49 | 1 | 349 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
added 1 commit
- c98fe759 - Work items widgets: Migrate to shared widget component
added 1 commit
- 2b0f56a8 - Work items widgets: Migrate to shared widget component
added 1 commit
- ebe34883 - Work items widgets: Migrate to shared widget component
changed milestone to %17.4
Security policy violations have been resolved.
Edited by GitLab Security Botadded 1483 commits
-
ebe34883...19686661 - 1482 commits from branch
master
- d3b27a5e - Work items widgets: Migrate to shared widget component
-
ebe34883...19686661 - 1482 commits from branch
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 1651959f and 818b93e3
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.32 MB 4.32 MB - -0.0 % mainChunk 3.27 MB 3.27 MB - 0.0 %
Note: We do not have exact data for 1651959f. So we have used data from: 0f1aa714.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 1 commit
- 6fbf9af6 - Work items widgets: Migrate to shared widget component
added 1 commit
- 9bf25f41 - Work items widgets: Migrate to shared widget component
added 1 commit
- fd70d986 - Work items widgets: Migrate to shared widget component
added 1 commit
- 2c88d5d7 - Work items widgets: Migrate to shared widget component
- Resolved by Sascha Eggenberger
Hey @annabeldunstone can you do the UX review here?
Note that the mobile styles will be improved with Related merge reqeust widget: Migrate to crud c... (!161803 - merged)
TY!
requested review from @annabeldunstone
removed review request for @annabeldunstone
added pipeline:mr-approved label
- Resolved by Florie Guibert
requested review from @fguibert
mentioned in merge request !163287 (merged)
added 1 commit
- 7db07631 - Work items widgets: Migrate to shared widget component
added 1 commit
- a9242167 - Work items widgets: Migrate to shared widget component
- Resolved by Florie Guibert
- Resolved by Sascha Eggenberger
added groupproduct planning label and removed groupux paper cuts label
mentioned in merge request !163292 (merged)
added 1 commit
- 196236d4 - Work items widgets: Migrate to shared widget component
added 1 commit
- dc6f2943 - Work items widgets: Migrate to shared widget component
added 1 commit
- b3bedd1c - Work items widgets: Migrate to shared widget component
added 1 commit
- 247bbcef - Work items widgets: Migrate to shared widget component
- Resolved by Florie Guibert
- Resolved by Florie Guibert
added 854 commits
-
247bbcef...33eccebe - 853 commits from branch
master
- 5f89b25e - Work items widgets: Migrate to shared widget component
-
247bbcef...33eccebe - 853 commits from branch
requested review from @fguibert
added 1 commit
- ada303bd - Work items widgets: Migrate to shared widget component
added 1200 commits
-
ada303bd...b8d5c6af - 1199 commits from branch
master
- 2a6586b2 - Work items widgets: Migrate to shared widget component
-
ada303bd...b8d5c6af - 1199 commits from branch
added 1 commit
- 818b93e3 - Work items widgets: Migrate to shared widget component
started a merge train
mentioned in commit 01fbd3ef
mentioned in merge request !164306 (merged)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue #481900 (closed)
- Resolved by Nick Brandt
@seggenberger a few things related to this MR:
-
Were the dividers between the widget collapse buttons and actions supposed to go away? I see them in the screenshots of this MR, but not on what's on production (maybe a different MR touched this)?
-
This adds counts to the Child widget, which isn't needed (it is being handled in a separate MR/effort). As seen in the screenshot above, with what is implemented it utilizes the
issue-type-task
icon in every instance, which isn't correct (this Child widget is also used on Epics and Objectives for example). Rajan has already started an MR to remove this (!164306 (merged)). -
This MR changes the icon we use on the Linked items widget count to use
issues
, where we previously were using thelink
icon. Issues isn't suitable here, as you can actually link multiple different types of work items in this widget (not just Issues). We will be updating this to be abadge
to match the Child items count soon, but this should remain thelink
icon until then.
I saw I was suggested as UX reviewer on this, and I'd greatly appreciate if you could ping me when working through MRs that are specific to groupproduct planning that may have effects on the frontend
We are working towards releasing the new Epic work item experience to GA soon, so things like this will be important to catch ahead of time in the future.Edited by Nick Brandt -
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in merge request !165681 (merged)
added releasedcandidate label
mentioned in merge request !165347 (merged)
added releasedpublished label and removed releasedcandidate label