Skip to content
Snippets Groups Projects

Work items child widget: Migrate to crud

Merged Sascha Eggenberger requested to merge work-items-widgets-migration into master
All threads resolved!

What does this MR do and why?

Migrates work items widgets to the shared widget component and removes it's own widget wrapper component.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
before after
before_items after_items
before_form after_form
before_child after_child

How to set up and validate locally

  1. Go to an work item, e.g. Objective

Related to #452231 (closed), #476988, !161791 (diffs)

Edited by Sascha Eggenberger

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sascha Eggenberger changed the description

    changed the description

  • mentioned in merge request !163292 (merged)

  • Sascha Eggenberger changed title from Work items widgets: Migrate to shared widget component to Work items child widget: Migrate to crud

    changed title from Work items widgets: Migrate to shared widget component to Work items child widget: Migrate to crud

  • added 1 commit

    • 196236d4 - Work items widgets: Migrate to shared widget component

    Compare with previous version

  • added 1 commit

    • dc6f2943 - Work items widgets: Migrate to shared widget component

    Compare with previous version

  • added 1 commit

    • b3bedd1c - Work items widgets: Migrate to shared widget component

    Compare with previous version

  • added 1 commit

    • 247bbcef - Work items widgets: Migrate to shared widget component

    Compare with previous version

  • Florie Guibert
  • Florie Guibert requested changes

    requested changes

  • Sascha Eggenberger added 854 commits

    added 854 commits

    Compare with previous version

  • requested review from @fguibert

  • added 1 commit

    • ada303bd - Work items widgets: Migrate to shared widget component

    Compare with previous version

  • Sascha Eggenberger added 1200 commits

    added 1200 commits

    Compare with previous version

  • added 1 commit

    • 818b93e3 - Work items widgets: Migrate to shared widget component

    Compare with previous version

  • Florie Guibert approved this merge request

    approved this merge request

  • Florie Guibert resolved all threads

    resolved all threads

  • Florie Guibert enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Florie Guibert mentioned in commit 01fbd3ef

    mentioned in commit 01fbd3ef

  • Rajan Mistry mentioned in merge request !164306 (merged)

    mentioned in merge request !164306 (merged)

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #481900 (closed)

    • Resolved by Nick Brandt

      @seggenberger a few things related to this MR:

      Screenshot_2024-08-29_at_4.09.19_PM

      • Were the dividers between the widget collapse buttons and actions supposed to go away? I see them in the screenshots of this MR, but not on what's on production (maybe a different MR touched this)?

      • This adds counts to the Child widget, which isn't needed (it is being handled in a separate MR/effort). As seen in the screenshot above, with what is implemented it utilizes the issue-type-task icon in every instance, which isn't correct (this Child widget is also used on Epics and Objectives for example). Rajan has already started an MR to remove this (!164306 (merged)).

      • This MR changes the icon we use on the Linked items widget count to use issues, where we previously were using the link icon. Issues isn't suitable here, as you can actually link multiple different types of work items in this widget (not just Issues). We will be updating this to be a badge to match the Child items count soon, but this should remain the link icon until then.

      I saw I was suggested as UX reviewer on this, and I'd greatly appreciate if you could ping me when working through MRs that are specific to groupproduct planning that may have effects on the frontend :pray: We are working towards releasing the new Epic work item experience to GA soon, so things like this will be important to catch ahead of time in the future.

      Edited by Nick Brandt
  • Sascha Eggenberger resolved all threads

    resolved all threads

  • Rajan Mistry mentioned in merge request !165681 (merged)

    mentioned in merge request !165681 (merged)

  • mentioned in merge request !165347 (merged)

  • Please register or sign in to reply
    Loading