Protected packages + containers: Define spacing in parent element

• Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA

What does this MR do and why?

• This follow-up MR is a suggestion that comes from another MR review
• Move style regarding spacing to the parent element
• This MR waits for !158600 (merged) to be merged

with at Siemens

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

MR Checklist (@gerardo-navarro)

• Changelog entry added, if necessary
• Documentation created/updated via this MR
• Documentation reviewed by technical writer or follow-up review issue created
• Tests added for this feature/bug
• Tested in all supported browsers
• Conforms to the code review guidelines
• Conforms to the merge request performance guidelines
• Conforms to the style guides
• Conforms to the javascript style guides
• Conforms to the database guides

Screenshots or screen recordings

No frontend change. The intention was that the styling stays the same.

Scenario 1: Badge "Cleanup" and badge "protected"

Before	After

Scenario 2: Only badge "protected"

Before	After

Scenario 3: Tags and Badge "protected" in package registry

Only minimal spacing changes.

Before	After

How to set up and validate locally

1. Enable the container registry in you local gdk
2. Push a container image for a container respository path
3. Go to the container repository overview page: http://gdk.test:3000/flightjs/Flight/container_registry
4. In the table, you should see a table entry for the pushed container repository, but without the badge "protected"
5. Go to the project settings and protect a certain container repository: http://gdk.test:3000/flightjs/Flight/-/settings/packages_and_registries
6. Go to the container repository overview page: http://gdk.test:3000/flightjs/Flight/-/settings/packages_and_registries
7. In the table, you should see a table entry for the pushed container repository with the badge "protected"

You follow the similar steps to validate the package registry.

Related to #467718 (closed)

marked this merge request as draft

added devopspackage groupcontainer registry sectionci typefeature labels

added Leading Organization label

changed the description

added pipelinetier-1 label

Thanks for your contribution to GitLab @gerardo-navarro!

• If you need help, comment @gitlab-bot help or come say hi on Discord.
• When you're ready for a review, comment on this merge request with @gitlab-bot ready.
• Tip: Start @gitlab-bot commands at the beginning of a new comment and do not wrap the command in quotes or backticks.
• We welcome AI-generated contributions! Read more/check the box at the top of the merge request description.
• To add labels to your merge request, comment @gitlab-bot label ~"label1" ~"label2".

This message was generated automatically. You're welcome to improve it.

added Community contribution workflowin dev labels

assigned to @gerardo-navarro

changed the description

added linked-issue label

	3 Warnings
	This merge request changed files with disabled eslint rules. Please consider fixing them.
	This merge request does not refer to an existing milestone.
	This merge request changed undocumented Vue components in vue_shared/. Please consider creating Stories for these components: app/assets/javascripts/vue_shared/components/registry/list_item.vue

Disabled eslint rules

The following files have disabled eslint rules. Please consider fixing them:

• app/assets/javascripts/vue_shared/components/registry/list_item.vue

Run the following command for more details

node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \
  'app/assets/javascripts/vue_shared/components/registry/list_item.vue'

Reviewer roulette

Category	Reviewer	Maintainer
frontend	@vvempati (UTC+12)	@dmishunov (UTC+2)
UX	@pedroms (UTC+1)	Maintainer review is optional for UX

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

changed the description

mentioned in merge request !158600 (merged)

@gerardo-navarro thanks for creating a follow-up regarding the shared badge. Once this is ready you can assign it to me for review

changed title from Draft: Protected containers: Badge "protected" in container registry list to Draft: Protected containers: Define spacing in parent element

changed title from Draft: Protected containers: Define spacing in parent element to Draft: Protected packages + containers: Define spacing in parent element

changed the description

changed the description

added 859 commits

• c07488aa...3b7e2dfe - 858 commits from branch gitlab-org:master
• 5c4de59b - refactor: Define spacing in parent element

Compare with previous version

marked this merge request as ready

added UX frontend labels

added workflowready for review label and removed workflowin dev label

requested review from @seggenberger and @syarynovskyi

Thanks for helping us improve the UX of GitLab. Your contribution is appreciated! We have pinged our UX team, so stay tuned for their feedback.

This message was generated automatically. You're welcome to improve it.

@syarynovskyi @seggenberger, this Community contribution is ready for review.

• Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
• If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.

This message was generated automatically. You're welcome to improve it.

added 1 commit

• fd51031c - refactor: Define spacing in parent element

Compare with previous version

I have reviewed the merge request and suggested replacing an outdated CSS class with its new equivalent.

requested changes

Security policy violations have been resolved.

added 1 commit

• 8b5f65cb - refactor: Define spacing in parent element

Compare with previous version

approved this merge request

removed review request for @syarynovskyi

added pipeline:mr-approved label

added pipelinetier-2 label and removed pipelinetier-1 label

Before you set this MR to auto-merge

This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3.

Before you set this MR to auto-merge, please check the following:

• You are the last maintainer of this merge request
• The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
• This pipeline is recent enough (created in the last 8 hours)

If all the criteria above apply, please set auto-merge for this merge request.

See pipeline tiers and merging a merge request for more details.

mentioned in issue gitlab-org/quality/triage-reports#19193 (closed)

requested changes

approved this merge request

removed review request for @seggenberger

Hi @seggenberger

We noticed this MR is marked as workflowready for review but no reviewer is assigned. workflowin dev has automatically been applied to this MR based on the likelihood the review is finished. If additional reviews are still required, please assign a reviewer and reapply workflowready for review.

@gerardo-navarro you may also request a review by commenting @gitlab-bot ready. You can also assign reviewers directly using @gitlab-bot ready @user1 @user2 if you know the relevant reviewer(s), such as those who were involved in a related issue.

This message was generated automatically. You're welcome to improve it.

added workflowin dev label and removed workflowready for review label

added 1 commit

• d7d0beff - refactor: Apply suggestions from @seggenberger

Compare with previous version

added 930 commits

• d7d0beff...5f242e08 - 928 commits from branch gitlab-org:master
• b6fd6d0a - refactor: Define spacing in parent element
• 13d4f602 - gco spe

Compare with previous version

added 1 commit

• 23141c75 - refactor: Apply suggestion from @seggenberger

Compare with previous version

added 1 commit

• b9797b0e - refactor: Apply suggestion from @seggenberger

Compare with previous version

added workflowready for review label and removed workflowin dev label

requested review from @dmishunov

@dmishunov, this Community contribution is ready for review.

• Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
• If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.

This message was generated automatically. You're welcome to improve it.

approved this merge request

added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label

resolved all threads

enabled automatic add to merge train when checks pass

	3 Warnings
	This merge request changed files with disabled eslint rules. Please consider fixing them.
	This merge request does not refer to an existing milestone.
	This merge request changed undocumented Vue components in vue_shared/. Please consider creating Stories for these components: app/assets/javascripts/vue_shared/components/registry/list_item.vue

Disabled eslint rules

The following files have disabled eslint rules. Please consider fixing them:

• app/assets/javascripts/vue_shared/components/registry/list_item.vue

Run the following command for more details

node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \
  'app/assets/javascripts/vue_shared/components/registry/list_item.vue'

Reviewer roulette

Category	Reviewer	Maintainer
frontend	@vvempati (UTC+12)	@dmishunov (UTC+2)
UX	@pedroms (UTC+1)	Maintainer review is optional for UX

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits d3bf5881 and b9797b0e

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	4.31 MB	4.31 MB	-	-0.0 %
mainChunk	3.26 MB	3.26 MB	-	0.0 %

---

Note: We do not have exact data for d3bf5881. So we have used data from: 9197c2b8.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for b9797b0e

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Plan        | 70     | 0      | 0       | 0     | 70    | ✅     |
| Verify      | 44     | 0      | 2       | 0     | 46    | ✅     |
| Create      | 127    | 0      | 12      | 0     | 139   | ✅     |
| Data Stores | 31     | 0      | 1       | 0     | 32    | ✅     |
| Govern      | 71     | 0      | 0       | 0     | 71    | ✅     |
| Package     | 16     | 0      | 12      | 0     | 28    | ✅     |
| Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
| Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
| Secure      | 2      | 0      | 0       | 0     | 2     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 379    | 0      | 28      | 0     | 407   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

started a merge train

merged

@gerardo-navarro, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

1. React with a or a on this comment to describe your experience.
2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.

Thanks for your help!

This message was generated automatically. You're welcome to improve it.

mentioned in commit eb85ff78

added workflowstaging-canary label and removed workflowready for review label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

changed milestone to %17.4

added workflowpost-deploy-db-staging label and removed workflowproduction label

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label