Shift anchor icon to the left for headers inside a summary tag
What does this MR do and why?
When a user adds an h1, h2, h3, h4, h5 or h6 to their markdown/RTE content, we automatically render an icon link to the left of it that navigates to the skiplink for that header.
When the user has placed this header inside a <summary>
tag, the skiplink and the summary toggle currently clash. This MR shifts the link icon to the left in this case so there is room for both.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
Screen_Recording_2024-08-26_at_11.39.36 | Screen_Recording_2024-08-26_at_11.38.52 |
How to set up and validate locally
- Check out this branch
- Create an issue in the GDK
- Add the following text to the issue description, then save it:
<details>
<summary>
# I'm an h1
</summary>
Hello, World!
</details>
<details>
<summary>
## I'm an h2
</summary>
Hello, World!
</details>
<details>
<summary>
### I'm an h3
</summary>
Hello, World!
</details>
<details>
<summary>
#### I'm an h4
</summary>
Hello, World!
</details>
<details>
<summary>
##### I'm an h5
</summary>
Hello, World!
</details>
<details>
<summary>
###### I'm an h6
</summary>
Hello, World!
</details>
- Hover over the headings. The link icon will display to the left of the summary toggle and will be independently clickable.
Related to #463329 (closed), #469616 (closed)
Merge request reports
Activity
assigned to @clavimoniere
added pipelinetier-1 label
changed milestone to %17.4
- A deleted user
added frontend label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Category Reviewer Maintainer frontend @agulina
(UTC+2, 6 hours ahead of author)
@anna_vovchenko
(UTC+3, 7 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerSecurity policy violations have been resolved.
Edited by GitLab Security Botadded 1592 commits
-
f59bd7e9...7b5b756c - 1591 commits from branch
master
- db40cf2b - Shift anchor icon to the left for headers inside a summary tag
-
f59bd7e9...7b5b756c - 1591 commits from branch
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits ba35ae8c and 8eaccb8f
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.31 MB 4.31 MB - 0.0 % mainChunk 3.27 MB 3.27 MB - 0.0 %
Note: We do not have exact data for ba35ae8c. So we have used data from: 14bb9a47.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 173 commits
-
db40cf2b...ddd54f77 - 172 commits from branch
master
- 5121708d - Shift anchor icon to the left for headers inside a summary tag
-
db40cf2b...ddd54f77 - 172 commits from branch
added 155 commits
-
5121708d...bf6f3a92 - 154 commits from branch
master
- ecc627fe - Shift anchor icon to the left for headers inside a summary tag
-
5121708d...bf6f3a92 - 154 commits from branch
added 1702 commits
-
ecc627fe...a426f619 - 1701 commits from branch
master
- 8eaccb8f - Shift anchor icon to the left for headers inside a summary tag
-
ecc627fe...a426f619 - 1701 commits from branch
- Resolved by Anna Vovchenko
@nickleonard can you do a UX review here?
requested review from @nickleonard
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
removed review request for @nickleonard
- Resolved by Anna Vovchenko
@anna_vovchenko can you do a frontend maintainer review on this?
requested review from @anna_vovchenko
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 8eaccb8fexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 71 | 0 | 0 | 0 | 71 | ✅ | | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Plan | 73 | 0 | 0 | 0 | 73 | ✅ | | Create | 128 | 0 | 15 | 0 | 143 | ✅ | | Package | 20 | 0 | 12 | 0 | 32 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Secure | 3 | 0 | 0 | 0 | 3 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 388 | 0 | 31 | 0 | 419 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 8eaccb8fexpand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Plan | 82 | 0 | 9 | 0 | 91 | ✅ | | Create | 270 | 0 | 34 | 0 | 304 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 352 | 0 | 43 | 0 | 395 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
removed pipeline:run-e2e-omnibus-once label
started a merge train
mentioned in commit b1e2b310
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!3354 (merged)
added releasedpublished label and removed releasedcandidate label
mentioned in merge request !170699 (merged)