Align position and styling of general settings on group and project

• Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA

What does this MR do and why?

Align position and styling of general settings on group and project.

Update global search controller.

Closes: #443544 (closed)

EE: true

Changelog: changed

Screenshots or screen recordings

Before	After
	project_after.mov group_after.mov

How to set up and validate locally

1. Run GDK .
2. Navigate to group / project settings -> General.

added pipelinetier-1 label

added Leading Organization label

Thanks for your contribution to GitLab @antonkalmykov!

• If you need help, comment @gitlab-bot help or come say hi on Discord.
• When you're ready for a review, comment on this merge request with @gitlab-bot ready.
• Tip: Start @gitlab-bot commands at the beginning of a new comment and do not wrap the command in quotes or backticks.
• We welcome AI-generated contributions! Read more/check the box at the top of the merge request description.
• To add labels to your merge request, comment @gitlab-bot label ~"label1" ~"label2".

This message was generated automatically. You're welcome to improve it.

added Community contribution workflowin dev labels

assigned to @antonkalmykov

changed the description

added linked-issue label

	2 Warnings
	This merge request contains lines with testid selectors. Please ensure e2e:package-and-test job is run.
	You've made some app changes, but didn't add any tests. That's OK as long as you're refactoring existing code, but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.

testid selectors

The following changed lines in this MR contain testid selectors:

app/views/projects/settings/_general.html.haml

-  = f.submit _('Save changes'), pajamas_button: true, class: "gl-mt-6", data: { testid: 'save-naming-topics-avatar-button' }
+  = f.submit _('Save changes'), pajamas_button: true, data: { testid: 'save-naming-topics-avatar-button' }

If the e2e:package-and-test job in the qa stage has run automatically, please ensure the tests are passing. If the job has not run, please start the manual:e2e-test-pipeline-generate job in the prepare stage and ensure the tests in follow-up:e2e:package-and-test-ee pipeline are passing.

For the list of known failures please refer to the latest pipeline triage issue.

If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.

Reviewer roulette

Category	Reviewer	Maintainer
backend	@Quintasan (UTC+2)	@alejandro (UTC-4)
frontend	@fernando-c (UTC-5)	@vitallium (UTC+2)
UX	@ameliabauerly (UTC-7)	Maintainer review is optional for UX
groupauthentication	Reviewer review is optional for groupauthentication	@sgarg_gitlab (UTC+5.5)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

Searchable setting sections

Looks like you have edited the template of some settings section. Please check that all changed sections are still searchable:

• If you created a new section, make sure to add it to either lib/search/project_settings.rb or lib/search/group_settings.rb, or in their counterparts in ee/ if this section is only available behind a licensed feature.
• If you removed a section, make sure to also remove it from the files above.
• If you changed a section's id, please update it also in the files above.
• If you just moved code around within the same page, there is nothing to do.
• If you are unsure what to do, please reach out to grouppersonal productivity.

app/views/groups/edit.html.haml

-  = render ::Layouts::SettingsBlockComponent.new(_('Naming, visibility'),
+  = render ::Layouts::SettingsBlockComponent.new(_('Naming, description, visibility'),

app/views/projects/edit.html.haml

-  = render ::Layouts::SettingsBlockComponent.new(_('Naming, topics, avatar'),
+  = render ::Layouts::SettingsBlockComponent.new(_('Naming, description, topics'),

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

marked this merge request as ready

changed the description

@gitlab-bot ready

@gitlab-bot label frontend backend UX Technical Writing

Could not add the following labels: Technical Writing

added UX backend frontend labels

added workflowready for review label and removed workflowin dev label

Thanks for helping us improve the UX of GitLab. Your contribution is appreciated! We have pinged our UX team, so stay tuned for their feedback.

This message was generated automatically. You're welcome to improve it.

Hi Coach @peterhegman, this Community contribution is ready for review or needs your coaching.

• Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
• If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.

This message was generated automatically. You're welcome to improve it.

requested review from @peterhegman

changed milestone to %17.3

requested review from @mnichols1

mentioned in issue gitlab-org/quality/triage-reports#19093 (closed)

added Technical Writing label

added grouptenant scale label

added devopsdata stores sectioncore platform labels

added typefeature label and removed grouptenant scale label

added grouptenant scale label

approved this merge request

removed review request for @mnichols1

added pipeline:mr-approved label

added pipelinetier-2 label and removed pipelinetier-1 label

Before you set this MR to auto-merge

This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3.

Before you set this MR to auto-merge, please check the following:

• You are the last maintainer of this merge request
• The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
• This pipeline is recent enough (created in the last 8 hours)

If all the criteria above apply, please set auto-merge for this merge request.

See pipeline tiers and merging a merge request for more details.

	2 Warnings
	This merge request contains lines with testid selectors. Please ensure e2e:package-and-test job is run.
	You've made some app changes, but didn't add any tests. That's OK as long as you're refactoring existing code, but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.

testid selectors

The following changed lines in this MR contain testid selectors:

app/views/projects/settings/_general.html.haml

-  = f.submit _('Save changes'), pajamas_button: true, class: "gl-mt-6", data: { testid: 'save-naming-topics-avatar-button' }
+  = f.submit _('Save changes'), pajamas_button: true, data: { testid: 'save-naming-topics-avatar-button' }

If the e2e:package-and-test job in the qa stage has run automatically, please ensure the tests are passing. If the job has not run, please start the manual:e2e-test-pipeline-generate job in the prepare stage and ensure the tests in follow-up:e2e:package-and-test-ee pipeline are passing.

For the list of known failures please refer to the latest pipeline triage issue.

If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.

Reviewer roulette

Category	Reviewer	Maintainer
backend	@janis (UTC+2)	@alejandro (UTC-4)
frontend	@lwanko (UTC+2)	@slashmanov (UTC+4)
UX	@ameliabauerly (UTC-7)	Maintainer review is optional for UX
groupauthentication	Reviewer review is optional for groupauthentication	@dblessing (UTC-5)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

Searchable setting sections

Looks like you have edited the template of some settings section. Please check that all changed sections are still searchable:

• If you created a new section, make sure to add it to either lib/search/project_settings.rb or lib/search/group_settings.rb, or in their counterparts in ee/ if this section is only available behind a licensed feature.
• If you removed a section, make sure to also remove it from the files above.
• If you changed a section's id, please update it also in the files above.
• If you just moved code around within the same page, there is nothing to do.
• If you are unsure what to do, please reach out to grouppersonal productivity.

app/views/groups/edit.html.haml

-  = render ::Layouts::SettingsBlockComponent.new(_('Naming, visibility'),
+  = render ::Layouts::SettingsBlockComponent.new(_('Naming, description, visibility'),

app/views/projects/edit.html.haml

-  = render ::Layouts::SettingsBlockComponent.new(_('Naming, topics, avatar'),
+  = render ::Layouts::SettingsBlockComponent.new(_('Naming, description, topics'),

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

thought (non-blocking): it is interesting how we have extra right padding on mobile. Looks kind of funky to me.

@seggenberger looks like you have worked on this in the past, any thoughts here?

question: Feels like there is a lot of extra space below the Remove avatar button:

Is there a specific reason we put so much space? @mnichols1 do you have any thoughts here? I would think it would be a standard 1rem spacing

Generated by gitlab_quality-test_tooling.

---

Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

Click to expand

Job	File	Name	Duration	Expected duration
#7532286051	ee/spec/lib/ee/search/group_settings_spec.rb#L17	Search results for settings behaves like all group settings sections exist and have correct anchor links has only valid settings sections	40.35 s	< 27.12 s
#7532286086	ee/spec/lib/ee/search/project_settings_spec.rb#L19	Search results for project settings behaves like all project settings sections exist and have correct anchor links has only valid settings sections	33.82 s	< 27.12 s
#7532285899	spec/lib/search/project_settings_spec.rb#L6	Search results for project settings behaves like all project settings sections exist and have correct anchor links has only valid settings sections	48.18 s	< 27.12 s
#7576266301	spec/lib/search/group_settings_spec.rb#L6	Search results for group settings behaves like all group settings sections exist and have correct anchor links has only valid settings sections	29.81 s	< 27.12 s
#7576266284	spec/lib/search/project_settings_spec.rb#L6	Search results for project settings behaves like all project settings sections exist and have correct anchor links has only valid settings sections	31.06 s	< 27.12 s
#7576266673	ee/spec/lib/ee/search/group_settings_spec.rb#L17	Search results for settings behaves like all group settings sections exist and have correct anchor links has only valid settings sections	42.77 s	< 27.12 s
#7576266573	ee/spec/lib/ee/search/project_settings_spec.rb#L19	Search results for project settings behaves like all project settings sections exist and have correct anchor links has only valid settings sections	50.31 s	< 27.12 s
#7587112283	spec/lib/search/group_settings_spec.rb#L6	Search results for group settings behaves like all group settings sections exist and have correct anchor links has only valid settings sections	37.24 s	< 27.12 s
#7587112473	ee/spec/lib/ee/search/group_settings_spec.rb#L17	Search results for settings behaves like all group settings sections exist and have correct anchor links has only valid settings sections	30.42 s	< 27.12 s
#7587112467	ee/spec/lib/ee/search/project_settings_spec.rb#L19	Search results for project settings behaves like all project settings sections exist and have correct anchor links has only valid settings sections	43.19 s	< 27.12 s
#7592567649	spec/lib/search/project_settings_spec.rb#L6	Search results for project settings behaves like all project settings sections exist and have correct anchor links has only valid settings sections	41.53 s	< 27.12 s
#7592568142	ee/spec/lib/ee/search/project_settings_spec.rb#L19	Search results for project settings behaves like all project settings sections exist and have correct anchor links has only valid settings sections	48.95 s	< 27.12 s

added rspec:slow test detected label

requested changes

requested review from @allison.browne

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 5bd11019

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Package     | 16     | 0      | 12      | 0     | 28    | ✅     |
| Create      | 127    | 0      | 12      | 0     | 139   | ✅     |
| Plan        | 70     | 0      | 0       | 0     | 70    | ✅     |
| Data Stores | 31     | 0      | 1       | 0     | 32    | ✅     |
| Verify      | 44     | 0      | 2       | 0     | 46    | ✅     |
| Govern      | 71     | 0      | 0       | 0     | 71    | ✅     |
| Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
| Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
| Secure      | 2      | 0      | 0       | 0     | 2     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 379    | 0      | 28      | 0     | 407   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for 5bd11019

expand test summary

+---------------------------------------------------------------------+
|                           suites summary                            |
+----------------+--------+--------+---------+-------+-------+--------+
|                | passed | failed | skipped | flaky | total | result |
+----------------+--------+--------+---------+-------+-------+--------+
| Data Stores    | 46     | 0      | 11      | 0     | 57    | ✅     |
| Monitor        | 12     | 0      | 13      | 0     | 25    | ✅     |
| Plan           | 82     | 0      | 9       | 0     | 91    | ✅     |
| Govern         | 107    | 0      | 6       | 0     | 113   | ✅     |
| GitLab Metrics | 2      | 0      | 1       | 0     | 3     | ✅     |
| Package        | 28     | 0      | 17      | 1     | 45    | ✅     |
| Verify         | 51     | 0      | 15      | 0     | 66    | ✅     |
| Create         | 417    | 0      | 51      | 0     | 468   | ✅     |
| Systems        | 7      | 0      | 0       | 0     | 7     | ✅     |
| Fulfillment    | 4      | 0      | 7       | 0     | 11    | ✅     |
| Manage         | 28     | 0      | 17      | 0     | 45    | ✅     |
| Analytics      | 3      | 0      | 0       | 0     | 3     | ✅     |
| Configure      | 1      | 0      | 3       | 0     | 4     | ✅     |
| Ai-powered     | 1      | 0      | 2       | 0     | 3     | ✅     |
| Secure         | 4      | 0      | 2       | 1     | 6     | ✅     |
| Growth         | 0      | 0      | 2       | 0     | 2     | ➖     |
| ModelOps       | 0      | 0      | 1       | 0     | 1     | ➖     |
| Release        | 5      | 0      | 1       | 0     | 6     | ✅     |
+----------------+--------+--------+---------+-------+-------+--------+
| Total          | 798    | 0      | 158     | 2     | 956   | ✅     |
+----------------+--------+--------+---------+-------+-------+--------+

enabled automatic add to merge train when checks pass

The ruby code here looks good to me.

approved this merge request

Security policy violations have been resolved.

added 2017 commits

• 096078da...04089aa3 - 2016 commits from branch gitlab-org:master
• 5bd11019 - Align position and styling of general settings on group and project

Compare with previous version

reset approvals from @allison.browne by pushing to the branch

mentioned in issue gitlab-org/quality/triage-reports#19193 (closed)

removed review request for @allison.browne

approved this merge request

resolved all threads

enabled automatic add to merge train when checks pass

cancelled automatic add to merge train

enabled automatic add to merge train when checks pass

cancelled automatic add to merge train

requested review from @dblessing

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 848d1d42 and 5bd11019

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	4.31 MB	4.31 MB	-	0.0 %
mainChunk	3.26 MB	3.26 MB	-	0.0 %

---

Note: We do not have exact data for 848d1d42. So we have used data from: 65f4acfb.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

resolved all threads

approved this merge request

added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label

enabled automatic add to merge train when checks pass

removed pipeline:run-e2e-omnibus-once label

mentioned in issue gitlab-org/quality/engineering-productivity/team#500 (closed)

started a merge train

merged

@antonkalmykov, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

1. React with a or a on this comment to describe your experience.
2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.

Thanks for your help!

This message was generated automatically. You're welcome to improve it.

mentioned in commit 250c595f

added workflowstaging-canary label and removed workflowready for review label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added workflowpost-deploy-db-staging label and removed workflowproduction label

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label