Skip to content

Catch BlockedUrlError when dispatching external status check

Alan (Maciej) Paruszewski requested to merge alan-catch-url-blocked-error-when-dispatching-external-status-check into master

What does this MR do and why?

This MR catches BlockedUrlError that might occur when user provides invalid URL in external status check.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  1. Create new project
  2. Within that project, create new External Status Check (https://docs.gitlab.com/ee/user/project/merge_requests/status_checks.html) with invalid URL.
  3. Observe logs for Sidekiq/exceptions logged in tail -f log/sidekiq.log and tail -f log/exceptions_json.log.
  4. You should not see any exception casued by invalid URL.
Edited by Alan (Maciej) Paruszewski

Merge request reports