Migrate terraform states GlCard to CrudComponent
Merge request reports
Activity
changed milestone to %17.3
added UX UX Paper Cuts frontend maintenanceusability typemaintenance labels
assigned to @annabeldunstone
added pipelinetier-1 label
- Resolved by Annabel Dunstone Gray
- A deleted user
added backend label
Reviewer roulette
Category Reviewer Maintainer backend @atiwari71
(UTC+5.5, 5.5 hours ahead of author)
@radbatnag
(UTC+8, 8 hours ahead of author)
frontend @mcavoj
(UTC+2, 2 hours ahead of author)
@justin_ho
(UTC+7, 7 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1 commit
- c1cfe070 - Migrate terraform states GlCard to CrudComponent
requested review from @jmiocene
- Resolved by Annabel Dunstone Gray
@tigerwnz Would you be able to take a look at this? This page has remained relatively untouched for a while but it looks like you contributed some changes in Show Terraform state deleted status in UI (!89190 - merged). I don't think I have everything set up locally so want to make sure this doesn't break anything
requested review from @tigerwnz
requested review from @anna_vovchenko and removed review request for @tigerwnz
- Resolved by Annabel Dunstone Gray
- Resolved by Annabel Dunstone Gray
added 1 commit
- 37fd3064 - Migrate terraform states GlCard to CrudComponent
- Resolved by Annabel Dunstone Gray
Reassigning @seggenberger since you already reviewed it
requested review from @seggenberger and removed review request for @jmiocene
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
removed review request for @seggenberger
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 09f23a94expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 70 | 0 | 0 | 0 | 70 | ✅ | | Create | 127 | 0 | 12 | 0 | 139 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Data Stores | 30 | 0 | 1 | 0 | 31 | ✅ | | Govern | 71 | 0 | 0 | 0 | 71 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Verify | 43 | 0 | 2 | 0 | 45 | ✅ | | Package | 16 | 0 | 15 | 0 | 31 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Secure | 2 | 0 | 0 | 0 | 2 | ✅ | | Fulfillment | 1 | 0 | 0 | 0 | 1 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 375 | 0 | 31 | 0 | 406 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Annabel Dunstone Gray
Nice work, @annabeldunstone! I found one small UI issue though:
As we removed all the
gl-flex
classes from the table, the loading icons and badges look funny:Current Expected Also, the pipeline column looks misaligned on the mobiles:
Current Expected You can see the additional loading icons and badges when clicking on actions menu -> lock state or delete state.
This change fixes the issues for me:
diff --git a/app/assets/javascripts/terraform/components/states_table.vue b/app/assets/javascripts/terraform/components/states_table.vue index 9bd646918244..de95e4c0de06 100644 --- a/app/assets/javascripts/terraform/components/states_table.vue +++ b/app/assets/javascripts/terraform/components/states_table.vue @@ -137,29 +137,27 @@ export default { stacked="md" > <template #cell(name)="{ item }"> - <div data-testid="terraform-states-table-name"> + <div + data-testid="terraform-states-table-name" + class="gl-flex gl-align-center gl-justify-end md:gl-justify-start gl-gap-3" + > <p class="gl-m-0 gl-text-gray-900"> {{ item.name }} </p> - <div v-if="item.loadingLock" class="gl-mx-3"> - <p> - <gl-loading-icon size="sm" class="gl-pr-1" /> - {{ loadingLockText(item) }} - </p> + <div v-if="item.loadingLock"> + <gl-loading-icon size="sm" class="gl-pr-1 gl-inline" /> + {{ loadingLockText(item) }} </div> - <div v-else-if="item.loadingRemove" class="gl-mx-3"> - <p> - <gl-loading-icon size="sm" class="gl-pr-1" /> - {{ $options.i18n.removing }} - </p> + <div v-else-if="item.loadingRemove"> + <gl-loading-icon size="sm" class="gl-pr-1 gl-inline" /> + {{ $options.i18n.removing }} </div> <div v-else-if="item.deletedAt" v-gl-tooltip.right - class="gl-mx-3" :title="$options.i18n.deletionInProgress" :data-testid="`state-badge-${item.name}`" > @@ -171,7 +169,6 @@ export default { <div v-else-if="item.lockedAt" v-gl-tooltip.right - class="gl-mx-3" :title="lockedByUserText(item)" :data-testid="`state-badge-${item.name}`" > @@ -183,7 +180,10 @@ export default { </template> <template #cell(pipeline)="{ item }"> - <div data-testid="terraform-states-table-pipeline" class="gl-flex gl-gap-3 gl-items-center"> + <div + data-testid="terraform-states-table-pipeline" + class="gl-flex gl-gap-3 gl-items-center gl-justify-end md:gl-justify-start" + > <gl-link v-if="pipelineID(item)" :href="pipelinePath(item)"> #{{ pipelineID(item) }} </gl-link>
mentioned in issue #476988
added 191 commits
-
37fd3064...4668a292 - 190 commits from branch
master
- a5b68fed - Migrate terraform states GlCard to CrudComponent
-
37fd3064...4668a292 - 190 commits from branch
- Resolved by Annabel Dunstone Gray
added 181 commits
-
a5b68fed...91b9c464 - 180 commits from branch
master
- 1ba670a7 - Migrate terraform states GlCard to CrudComponent
-
a5b68fed...91b9c464 - 180 commits from branch
- Resolved by Annabel Dunstone Gray
added 1 commit
- 09f23a94 - Migrate terraform states GlCard to CrudComponent
Thanks for the great work here, @annabeldunstone! Let's get it merged
added pipelinetier-3 label and removed pipelinetier-2 label
mentioned in commit 9cfa7fa2
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!3241 (merged)