Add bluesky field to the user profile
What does this MR do and why?
Adds a profile field for bluesky did:plc identifier
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() ![]() |
The user profile side contact info
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Add proper did:plc to your user profile (see https://atproto.com/specs/did)
- Go to the user profile
Related to #451690 (closed)
Merge request reports
Activity
assigned to @eduardosanz
added devopsgovern groupauthentication sectionsec typefeature labels
added pipelinetier-1 label
Database migrations (on the main database)
1 Warnings 20240730163326 - AddBlueskyToUserDetails had a query that exceeded timing guidelines. Run
time should not exceed 100ms, but it was 10307.3ms. Please consider possible options to improve the
query performance.ALTER TABLE user_details VALIDATE CONSTRAINT check_18a53381cd
Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).
Migration Type Total runtime Result DB size change 20240730163326 - AddBlueskyToUserDetails Regular 16.4 s +0.00 B Runtime Histogram for all migrations
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 3 0.1 seconds - 1 second 2 1 second - 5 seconds 0 5 seconds - 15 seconds 1 15 seconds - 5 minutes 0 5 minutes + 0 Migration: 20240730163326 - AddBlueskyToUserDetails- Type: Regular
- Duration: 16.4 s
- Database size change: +0.00 B
Calls Total Time Max Time Mean Time Rows Query 1 10307.3 ms 10307.3 ms 10307.3 ms 0 ALTER TABLE user_details VALIDATE CONSTRAINT check_18a53381cd
1 8.6 ms 8.6 ms 8.6 ms 0 ALTER TABLE user_details ADD CONSTRAINT check_18a53381cd CHECK ( char_length(bluesky) <= 256 ) NOT VALID
1 1.4 ms 1.4 ms 1.4 ms 0 ALTER TABLE "user_details" ADD "bluesky" text DEFAULT '' NOT NULL
2 0.0 ms 0.0 ms 0.0 ms 2 SELECT pg_backend_pid()
1 0.0 ms 0.0 ms 0.0 ms 1 SELECT $1::regtype::oid
Histogram for AddBlueskyToUserDetails
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 3 0.1 seconds - 1 second 2 1 second - 5 seconds 0 5 seconds - 15 seconds 1 15 seconds - 5 minutes 0 5 minutes + 0 Background Migration: BackfillVulnerabilityFindingLinksProjectId
Sampled 89 batches. Estimated Time to complete: 1 year, 7 months, 1 week, 2 days, 7 hours, 3 minutes, and 6 seconds
- Interval: 120s
- Total tuple count: 423068670
- Max batch size: 0
- Estimated seconds to complete: 50768160s
- Estimated number of batches: 423068
- Average batch time: 5.19s
- Batch size: 1000
- N. of batches sampled: 89
- N. of failed batches: 0
Time estimation is conservative and based on sampling production data in a test environment. It represents the max time that migration could take. The actual time may differ from this estimation.
_Consider changing max_batch_size and interval if this estimate is unacceptable._
Calls Total Time Max Time Mean Time Rows Query 801 22855.6 ms 367.8 ms 28.5 ms 80100 UPDATE vulnerability_finding_links
SET project_id = vulnerability_occurrences.project_id
FROM vulnerability_occurrences
WHERE vulnerability_occurrences.id = vulnerability_finding_links.vulnerability_occurrence_id AND vulnerability_finding_links.id IN (
SELECT vulnerability_finding_links.id
FROM vulnerability_finding_links
WHERE vulnerability_finding_links.id BETWEEN $1 AND $2 AND vulnerability_finding_links.project_id IS NULL AND vulnerability_finding_links.id >= $3 AND vulnerability_finding_links.id < $4
)89 2087.8 ms 231.3 ms 23.5 ms 8900 UPDATE vulnerability_finding_links
SET project_id = vulnerability_occurrences.project_id
FROM vulnerability_occurrences
WHERE vulnerability_occurrences.id = vulnerability_finding_links.vulnerability_occurrence_id AND vulnerability_finding_links.id IN (
SELECT vulnerability_finding_links.id
FROM vulnerability_finding_links
WHERE vulnerability_finding_links.id BETWEEN $1 AND $2 AND vulnerability_finding_links.project_id IS NULL AND vulnerability_finding_links.id >= $3
)890 105.2 ms 8.6 ms 0.1 ms 801 SELECT vulnerability_finding_links.id
FROM vulnerability_finding_links
WHERE vulnerability_finding_links.id BETWEEN $1 AND $2 AND vulnerability_finding_links.project_id IS NULL AND vulnerability_finding_links.id >= $3
ORDER BY vulnerability_finding_links.id ASC
LIMIT $4
OFFSET $5178 54.6 ms 6.3 ms 0.3 ms 178 INSERT INTO batched_background_migration_job_transition_logs (batched_background_migration_job_id, created_at, updated_at, previous_status, next_status) VALUES ($1, $2, $3, $4, $5) RETURNING id
178 13.5 ms 4.1 ms 0.1 ms 178 SELECT batched_background_migration_jobs.*
FROM batched_background_migration_jobs
WHERE batched_background_migration_jobs.id = $1
LIMIT $289 12.2 ms 1.1 ms 0.1 ms 89 UPDATE batched_background_migration_jobs
SET updated_at = $1, started_at = $2, status = $3, attempts = $4
WHERE batched_background_migration_jobs.id = $589 10.8 ms 0.9 ms 0.1 ms 89 UPDATE batched_background_migration_jobs
SET updated_at = $1, finished_at = $2, status = $3, metrics = $4
WHERE batched_background_migration_jobs.id = $589 4.2 ms 0.7 ms 0.0 ms 89 SELECT batched_background_migrations.*
FROM batched_background_migrations
WHERE batched_background_migrations.id = $1
LIMIT $289 6.8 ms 0.7 ms 0.1 ms 89 SELECT sum(batched_background_migration_jobs.batch_size)
FROM batched_background_migration_jobs
WHERE batched_background_migration_jobs.batched_background_migration_id = $1 AND batched_background_migration_jobs.status IN ($2)89 3.4 ms 0.1 ms 0.0 ms 89 SELECT vulnerability_finding_links.id
FROM vulnerability_finding_links
WHERE vulnerability_finding_links.id BETWEEN $1 AND $2 AND vulnerability_finding_links.project_id IS NULL
ORDER BY vulnerability_finding_links.id ASC
LIMIT $3Histogram of batch runtimes for BackfillVulnerabilityFindingLinksProjectId
Batch Runtime Count 0 seconds - 10 seconds 89 10 seconds - 1 minute 0 1 minute - 2 minutes 0 2 minutes - 3 minutes 0 3 minutes - 5 minutes 0 5 minutes + 0 Histogram across all sampled batches of BackfillVulnerabilityFindingLinksProjectId
Query Runtime Count 0 seconds - 0.1 seconds 1173 0.1 seconds - 0.5 seconds 1408 0.5 seconds - 1 second 0 1 second - 2 seconds 0 2 seconds - 5 seconds 0 5 seconds + 0 Background Migration: BackfillMergeRequestUserMentionsProjectId
Sampled 80 batches. Estimated Time to complete: 6 months, 2 weeks, 4 days, 21 hours, 7 minutes, and 24 seconds
- Interval: 120s
- Total tuple count: 145081490
- Max batch size: 0
- Estimated seconds to complete: 17409720s
- Estimated number of batches: 145081
- Average batch time: 5.74s
- Batch size: 1000
- N. of batches sampled: 80
- N. of failed batches: 0
Time estimation is conservative and based on sampling production data in a test environment. It represents the max time that migration could take. The actual time may differ from this estimation.
_Consider changing max_batch_size and interval if this estimate is unacceptable._
Calls Total Time Max Time Mean Time Rows Query 718 62044.3 ms 1157.4 ms 86.4 ms 71800 UPDATE merge_request_user_mentions
SET project_id = merge_requests.target_project_id
FROM merge_requests
WHERE merge_requests.id = merge_request_user_mentions.merge_request_id AND merge_request_user_mentions.id IN (
SELECT merge_request_user_mentions.id
FROM merge_request_user_mentions
WHERE merge_request_user_mentions.id BETWEEN $1 AND $2 AND merge_request_user_mentions.project_id IS NULL AND merge_request_user_mentions.id >= $3 AND merge_request_user_mentions.id < $4
)80 5793.9 ms 142.8 ms 72.4 ms 7949 UPDATE merge_request_user_mentions
SET project_id = merge_requests.target_project_id
FROM merge_requests
WHERE merge_requests.id = merge_request_user_mentions.merge_request_id AND merge_request_user_mentions.id IN (
SELECT merge_request_user_mentions.id
FROM merge_request_user_mentions
WHERE merge_request_user_mentions.id BETWEEN $1 AND $2 AND merge_request_user_mentions.project_id IS NULL AND merge_request_user_mentions.id >= $3
)80 15.3 ms 4.0 ms 0.2 ms 80 UPDATE batched_background_migration_jobs
SET updated_at = $1, started_at = $2, status = $3, attempts = $4
WHERE batched_background_migration_jobs.id = $5798 241.9 ms 3.1 ms 0.3 ms 718 SELECT merge_request_user_mentions.id
FROM merge_request_user_mentions
WHERE merge_request_user_mentions.id BETWEEN $1 AND $2 AND merge_request_user_mentions.project_id IS NULL AND merge_request_user_mentions.id >= $3
ORDER BY merge_request_user_mentions.id ASC
LIMIT $4
OFFSET $580 11.1 ms 1.9 ms 0.1 ms 80 UPDATE batched_background_migration_jobs
SET updated_at = $1, finished_at = $2, status = $3, metrics = $4
WHERE batched_background_migration_jobs.id = $5160 30.1 ms 1.8 ms 0.2 ms 160 INSERT INTO batched_background_migration_job_transition_logs (batched_background_migration_job_id, created_at, updated_at, previous_status, next_status) VALUES ($1, $2, $3, $4, $5) RETURNING id
160 8.7 ms 0.9 ms 0.1 ms 160 SELECT batched_background_migration_jobs.*
FROM batched_background_migration_jobs
WHERE batched_background_migration_jobs.id = $1
LIMIT $280 3.9 ms 0.8 ms 0.0 ms 80 SELECT merge_request_user_mentions.id
FROM merge_request_user_mentions
WHERE merge_request_user_mentions.id BETWEEN $1 AND $2 AND merge_request_user_mentions.project_id IS NULL
ORDER BY merge_request_user_mentions.id ASC
LIMIT $380 4.7 ms 0.3 ms 0.1 ms 80 SELECT sum(batched_background_migration_jobs.batch_size)
FROM batched_background_migration_jobs
WHERE batched_background_migration_jobs.batched_background_migration_id = $1 AND batched_background_migration_jobs.status IN ($2)80 3.4 ms 0.3 ms 0.0 ms 80 SELECT batched_background_migrations.*
FROM batched_background_migrations
WHERE batched_background_migrations.id = $1
LIMIT $2Histogram of batch runtimes for BackfillMergeRequestUserMentionsProjectId
Batch Runtime Count 0 seconds - 10 seconds 80 10 seconds - 1 minute 0 1 minute - 2 minutes 0 2 minutes - 3 minutes 0 3 minutes - 5 minutes 0 5 minutes + 0 Histogram across all sampled batches of BackfillMergeRequestUserMentionsProjectId
Query Runtime Count 0 seconds - 0.1 seconds 260 0.1 seconds - 0.5 seconds 2053 0.5 seconds - 1 second 2 1 second - 2 seconds 1 2 seconds - 5 seconds 0 5 seconds + 0 Background Migration: BackfillApprovalsProjectId
Sampled 46 batches. Estimated Time to complete: 3 weeks, 3 days, 7 hours, and 52 minutes
- Interval: 120s
- Total tuple count: 87581896
- Max batch size: 0
- Estimated seconds to complete: 2101920s
- Estimated number of batches: 17516
- Average batch time: 11.5s
- Batch size: 5000
- N. of batches sampled: 46
- N. of failed batches: 0
Time estimation is conservative and based on sampling production data in a test environment. It represents the max time that migration could take. The actual time may differ from this estimation.
_Consider changing max_batch_size and interval if this estimate is unacceptable._
Calls Total Time Max Time Mean Time Rows Query 414 279059.4 ms 1714.2 ms 674.1 ms 207000 UPDATE approvals
SET project_id = merge_requests.target_project_id
FROM merge_requests
WHERE merge_requests.id = approvals.merge_request_id AND approvals.id IN (
SELECT approvals.id
FROM approvals
WHERE approvals.id BETWEEN $1 AND $2 AND approvals.project_id IS NULL AND approvals.id >= $3 AND approvals.id < $4
)46 24563.2 ms 960.8 ms 534.0 ms 22860 UPDATE approvals
SET project_id = merge_requests.target_project_id
FROM merge_requests
WHERE merge_requests.id = approvals.merge_request_id AND approvals.id IN (
SELECT approvals.id
FROM approvals
WHERE approvals.id BETWEEN $1 AND $2 AND approvals.project_id IS NULL AND approvals.id >= $3
)460 548.6 ms 46.6 ms 1.2 ms 414 SELECT approvals.id
FROM approvals
WHERE approvals.id BETWEEN $1 AND $2 AND approvals.project_id IS NULL AND approvals.id >= $3
ORDER BY approvals.id ASC
LIMIT $4
OFFSET $546 7.3 ms 2.6 ms 0.2 ms 46 UPDATE batched_background_migration_jobs
SET updated_at = $1, started_at = $2, status = $3, attempts = $4
WHERE batched_background_migration_jobs.id = $592 20.8 ms 2.0 ms 0.2 ms 92 INSERT INTO batched_background_migration_job_transition_logs (batched_background_migration_job_id, created_at, updated_at, previous_status, next_status) VALUES ($1, $2, $3, $4, $5) RETURNING id
46 8.8 ms 1.9 ms 0.2 ms 46 UPDATE batched_background_migration_jobs
SET updated_at = $1, finished_at = $2, status = $3, metrics = $4
WHERE batched_background_migration_jobs.id = $546 2.5 ms 0.7 ms 0.1 ms 46 SELECT approvals.id
FROM approvals
WHERE approvals.id BETWEEN $1 AND $2 AND approvals.project_id IS NULL
ORDER BY approvals.id ASC
LIMIT $392 7.0 ms 0.7 ms 0.1 ms 92 SELECT batched_background_migration_jobs.*
FROM batched_background_migration_jobs
WHERE batched_background_migration_jobs.id = $1
LIMIT $246 2.9 ms 0.3 ms 0.1 ms 46 SELECT sum(batched_background_migration_jobs.batch_size)
FROM batched_background_migration_jobs
WHERE batched_background_migration_jobs.batched_background_migration_id = $1 AND batched_background_migration_jobs.status IN ($2)46 1.9 ms 0.1 ms 0.0 ms 46 SELECT batched_background_migrations.*
FROM batched_background_migrations
WHERE batched_background_migrations.id = $1
LIMIT $2Histogram of batch runtimes for BackfillApprovalsProjectId
Batch Runtime Count 0 seconds - 10 seconds 5 10 seconds - 1 minute 41 1 minute - 2 minutes 0 2 minutes - 3 minutes 0 3 minutes - 5 minutes 0 5 minutes + 0 Histogram across all sampled batches of BackfillApprovalsProjectId
Query Runtime Count 0 seconds - 0.1 seconds 78 0.1 seconds - 0.5 seconds 810 0.5 seconds - 1 second 388 1 second - 2 seconds 58 2 seconds - 5 seconds 0 5 seconds + 0 Other information
Other migrations pending on GitLab.com
Migration Type Total runtime Result DB size change 20240719090628 - AddProjectIdToApprovals Regular 5.6 s +0.00 B 20240724083115 - AddJacocoCoverageReportPlanLimit Regular 4.3 s +8.00 KiB [note] 20240729133632 - AddProjectIdToVulnerabilityFindingLinks Regular 4.2 s +0.00 B 20240719090629 - PrepareIndexApprovalsOnProjectId Post deploy 5.2 s +8.00 KiB [note] 20240719090630 - AddApprovalsProjectIdTrigger Post deploy 4.4 s +0.00 B 20240719090631 - QueueBackfillApprovalsProjectId Post deploy 5.2 s +0.00 B 20240725171360 - PrepareIndexMergeRequestUserMentionsOnProjectId Post deploy 4.9 s +0.00 B 20240725171400 - AddMergeRequestUserMentionsProjectIdTrigger Post deploy 4.5 s +0.00 B 20240725171401 - QueueBackfillMergeRequestUserMentionsProjectId Post deploy 4.9 s +0.00 B 20240729133633 - PrepareIndexVulnerabilityFindingLinksOnProjectId Post deploy 4.9 s +0.00 B 20240729133634 - AddVulnerabilityFindingLinksProjectIdTrigger Post deploy 4.5 s +0.00 B 20240729133635 - QueueBackfillVulnerabilityFindingLinksProjectId Post deploy 4.9 s +0.00 B Clone details
Clone ID Clone Created At Clone Data Timestamp Expected Removal Time database-testing-3559112-14833694-main
2024-07-30T19:39:07Z 2024-07-30T15:38:19Z 2024-07-31 08:16:43 +0000 database-testing-3559112-14833694-ci
2024-07-30T19:39:06Z 2024-07-30T16:45:51Z 2024-07-31 08:16:43 +0000 Database migrations (on the ci database)
Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).
Migration Type Total runtime Result DB size change 20240730163326 - AddBlueskyToUserDetails Regular 8.1 s +0.00 B Runtime Histogram for all migrations
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 3 0.1 seconds - 1 second 3 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Migration: 20240730163326 - AddBlueskyToUserDetails
- Type: Regular
- Duration: 8.1 s
- Database size change: +0.00 B
Calls Total Time Max Time Mean Time Rows Query 1 11.1 ms 11.1 ms 11.1 ms 0 ALTER TABLE user_details ADD CONSTRAINT check_18a53381cd CHECK ( char_length(bluesky) <= 256 ) NOT VALID
1 9.5 ms 9.5 ms 9.5 ms 0 ALTER TABLE "user_details" ADD "bluesky" text DEFAULT '' NOT NULL
1 2.1 ms 2.1 ms 2.1 ms 0 ALTER TABLE user_details VALIDATE CONSTRAINT check_18a53381cd
1 0.0 ms 0.0 ms 0.0 ms 1 SELECT $1::regtype::oid
2 0.0 ms 0.0 ms 0.0 ms 2 SELECT pg_backend_pid()
Histogram for AddBlueskyToUserDetails
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 3 0.1 seconds - 1 second 3 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Other information
Other migrations pending on GitLab.com
Migration Type Total runtime Result DB size change 20240719090628 - AddProjectIdToApprovals Regular 7.3 s +0.00 B 20240724083115 - AddJacocoCoverageReportPlanLimit Regular 6.4 s +8.00 KiB [note] 20240729133632 - AddProjectIdToVulnerabilityFindingLinks Regular 6.3 s +0.00 B 20240719090629 - PrepareIndexApprovalsOnProjectId Post deploy 7.1 s +8.00 KiB [note] 20240719090630 - AddApprovalsProjectIdTrigger Post deploy 6.6 s +0.00 B 20240719090631 - QueueBackfillApprovalsProjectId Post deploy 6.2 s +0.00 B 20240725171360 - PrepareIndexMergeRequestUserMentionsOnProjectId Post deploy 7.0 s +0.00 B 20240725171400 - AddMergeRequestUserMentionsProjectIdTrigger Post deploy 6.5 s +0.00 B 20240725171401 - QueueBackfillMergeRequestUserMentionsProjectId Post deploy 6.2 s +0.00 B 20240729133633 - PrepareIndexVulnerabilityFindingLinksOnProjectId Post deploy 7.1 s +0.00 B 20240729133634 - AddVulnerabilityFindingLinksProjectIdTrigger Post deploy 6.5 s +0.00 B 20240729133635 - QueueBackfillVulnerabilityFindingLinksProjectId Post deploy 6.2 s +0.00 B Clone details
Clone ID Clone Created At Clone Data Timestamp Expected Removal Time database-testing-3559112-14833694-main
2024-07-30T19:39:07Z 2024-07-30T15:38:19Z 2024-07-31 08:16:43 +0000 database-testing-3559112-14833694-ci
2024-07-30T19:39:06Z 2024-07-30T16:45:51Z 2024-07-31 08:16:43 +0000
Brought to you by gitlab-org/database-team/gitlab-com-database-testing. Epic
Edited by ****- A deleted user
added backend database databasereview pending documentation frontend labels
- Resolved by Eduardo Sanz García
- Resolved by Eduardo Sanz García
3 Warnings The master pipeline status page reported failures in - rspec-ee system pg14 15/16
- rspec unit pg14 single-db-ci-connection 16/44
- rspec unit pg14 single-db-ci-connection 13/44
- rspec unit pg14 single-db 16/44
- rspec unit pg14 single-db 13/44
If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.This merge request does not refer to an existing milestone. This merge request contains lines with testid selectors. Please ensure e2e:package-and-test
job is run.1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/user/profile/index.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/views/users/_profile_sidebar.html.haml
- .gl-display-flex.gl-gap-2.gl-mb-2{ data: { testid: 'user-local-time' } } + .gl-flex.gl-gap-2.gl-mb-2{ data: { testid: 'user-local-time' } }
If the
e2e:package-and-test
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:package-and-test-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer backend @syarynovskyi
(UTC+3, 1 hour ahead of author)
@nbelokolodov
(UTC+8, 6 hours ahead of author)
database @carlad-gl
(UTC+2, same timezone as author)
@jon_jenkins
(UTC-5, 7 hours behind author)
frontend @thutterer
(UTC+2, same timezone as author)
@pgascouvaillancourt
(UTC-4, 6 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
Tailwind CSS
Legacy CSS utility classes
The following files contain legacy CSS utility classes:
-
app/views/users/_profile_sidebar.html.haml
-
gl-flex-direction-column
- Tailwind CSS equivalent:gl-flex-col
-
gl-flex-direction-column
- Tailwind CSS equivalent:gl-flex-col
-
We are in the process of migrating our CSS utility classes to Tailwind CSS. The above CSS utility classes do not comply with Tailwind CSS naming conventions. Please use the Tailwind CSS equivalent if it is available. For more information see Tailwind CSS developer documentation.
If the Tailwind CSS equivalent is not available, it is okay to use the legacy CSS utility class for now. The Tailwind CSS equivalent will be made available when the corresponding migration issue in &13521 (closed) is completed.
If a legacy CSS utility class is listed above but you did not change it in this MR it is okay to leave for now. If it is a small or simple MR, feel free to leave the code better than you found it and migrate those legacy CSS utility classes to Tailwind CSS.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Eduardo Sanz García
added database-testing-automation label
added 2 commits
- Resolved by Eduardo Sanz García
- Resolved by David Pisek
This is a copy of !147733 (closed), which was pre-approved, but the community contributor didn't have capacity to finish it.
I am going to ask for maintainer approval only for the following areas:
UX and Technical Writing were approved in the closed MR and there are no changes here.
Thank you very much!
requested review from @bwill, @dblessing, and @dpisek
assigned to @SlickDomique
- Resolved by Eduardo Sanz García
- Resolved by Eduardo Sanz García
- Resolved by Eduardo Sanz García
aborted automatic add to merge train because the source branch was updated. Learn more.
added 201 commits
-
1d869a36...adaf0a90 - 198 commits from branch
master
- c4ece5ce - Add bluesky field to the user profile
- 2bb01a42 - Replace legacy CSS rule for Tailwind equivalent
- 3c9e6e3d - Adding rubocop comment
Toggle commit list-
1d869a36...adaf0a90 - 198 commits from branch
- Resolved by Eduardo Sanz García
added databasereviewed label and removed databasereview pending label
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
- Resolved by Eduardo Sanz García
added databaseapproved label and removed databasereviewed label
added pipelinetier-3 label and removed pipelinetier-2 label
@SlickDomique, you have done a great job here! Thank you very much for your contribution!
@hsutor, @SlickDomique did 99% of the job here, I just took it over to finish last touches and because @SlickDomique was busy.
Thank you @SlickDomique - you have a shout out in the release post.
Thanks for taking this over the line Eduardo.
mentioned in merge request !147733 (closed)
removed this merge request from the merge train because the pipeline did not succeed. Learn more.
- Resolved by Eduardo Sanz García
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #7484686957 spec/features/admin/users/users_spec.rb#L177
Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 65.6 s < 50.13 s #7484687081 spec/features/admin/users/users_spec.rb#L177
Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 66.5 s < 50.13 s #7484687172 spec/features/admin/users/users_spec.rb#L177
Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 66.7 s < 50.13 s - A deleted user
added rspec:slow test detected label
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 3c9e6e3dexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 43 | 0 | 2 | 0 | 45 | ✅ | | Create | 127 | 0 | 12 | 0 | 139 | ✅ | | Package | 16 | 0 | 15 | 0 | 31 | ✅ | | Govern | 71 | 0 | 0 | 0 | 71 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Plan | 70 | 0 | 0 | 0 | 70 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 30 | 0 | 1 | 0 | 31 | ✅ | | Fulfillment | 1 | 0 | 0 | 0 | 1 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Secure | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 375 | 0 | 31 | 0 | 406 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 3c9e6e3dexpand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Govern | 105 | 0 | 8 | 3 | 113 | ✅ | | Create | 270 | 0 | 34 | 0 | 304 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 375 | 0 | 42 | 3 | 417 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
added pipeline:skip-check-migrations label
Hello @eduardosanz
The database team is looking for ways to improve the database review process and we would love your help!
If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:
@gitlab-org/database-team
And someone will be by shortly!
Thanks for your help!
This message was generated automatically. You're welcome to improve it.