Remove CI dependency validation danger

changed milestone to %17.3

assigned to @jennli

Proper labels assigned to this merge request. Please ignore me.

@jennli - please see the following guidance and update this merge request.

	1 Error
	Please add typebug typefeature, or typemaintenance label to this merge request.

	1 Warning
	This merge request is quite big (920 lines changed), please consider splitting it into multiple merge requests.

Reviewer roulette

Category	Reviewer	Maintainer
~"Tooling"	Reviewer review is optional for ~"Tooling"	`@rymai` (UTC+2, 9 hours ahead of author)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added 1 commit

107b05ae - Remove CI dependency validation danger

Compare with previous version

requested review from @ddieulivol

added maintenancepipelines label

added typemaintenance label

changed the description

resolved all threads

mentioned in issue #34040 (closed)

mentioned in merge request !160277 (merged)

marked this merge request as draft

removed review request for @ddieulivol

To follow up on !160277 (comment 2022926292), If we feel this is the right step to take, I'm good with removing this danger.

I do still hope to give this another chance. One of the improvements I'm making is to change this to validate against merged result commit, this is done in Validate CI dependency against merged result co... (!161245 - merged). This will remove a lot of the noises we have been seeing due to branch being out of date, like in !160277 (merged).

After the improvement, if we still feel that this danger does not give us a lot of value, we can go ahead and remove it by merging this MR.

Alternatively, instead of removing everything, we can retain some of the useful part of the output to help with code reviews, such as

print the expanded YAML that are added/removed
identify which job are needed/impacted

the output would be more for informational purposes than a validation check. Let me know what you think.

cc @gl-quality/eng-prod

closed

reopened

changed milestone to %17.4

added 2303 commits

107b05ae...a705ceb6 - 2302 commits from branch master
09b6759e - Remove CI dependency validation danger

Compare with previous version

added 1 commit

882ad749 - Remove CI dependency validation danger

Compare with previous version

marked this merge request as ready

mentioned in issue gitlab-org/quality/engineering-productivity/internal-rotation#12 (closed)

@ddieulivol if you have time please review this MR, thanks!

requested review from @ddieulivol

resolved all threads

approved this merge request

added pipeline:mr-approved label

added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label

Before you set this MR to auto-merge

This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

Before you set this MR to auto-merge, please check the following:

You are the last maintainer of this merge request
The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
This pipeline is recent enough (created in the last 8 hours)

If all the criteria above apply, please set auto-merge for this merge request.

See pipeline tiers and merging a merge request for more details.